Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(release): Omit ai-nav helmrepos from bundle (#2135) #2136

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix(release): Omit ai-nav helmrepos from bundle (#2135) #2136

merged 1 commit into from
Apr 19, 2024

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Apr 16, 2024

  • refactor(helmrepos): Separate ai-navigator helmrepos into separate file

  • fix(release): Omit ai-nav helmrepos from bundle

What problem does this PR solve?:
backports #2135

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@gracedo
fix(release): Omit ai-nav helmrepos from bundle (#2135)
564ecc1 
* refactor(helmrepos): Separate ai-navigator helmrepos into separate file

* fix(release): Omit ai-nav helmrepos from bundle
@gracedo gracedo added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Apr 16, 2024
@gracedo gracedo self-assigned this Apr 16, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 16, 2024
@gracedo gracedo marked this pull request as ready for review April 16, 2024 21:28
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8712774031

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%
Totals Coverage Status
Change from base Build 8712045536: 0.0%
Covered Lines: 136
Relevant Lines: 171
💛 - Coveralls

@gracedo gracedo enabled auto-merge (squash) April 17, 2024 15:39
@gracedo gracedo requested a review from cwyl02 April 17, 2024 22:28
@gracedo gracedo merged commit 92e00f4 into main Apr 19, 2024
20 checks passed
@gracedo gracedo deleted the gracedo/xc_ainav_helmrepos branch April 19, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwyl02 cwyl02 cwyl02 approved these changes

@msdolbey msdolbey Awaiting requested review from msdolbey

@kaiwalyajoshi kaiwalyajoshi Awaiting requested review from kaiwalyajoshi

Assignees

@gracedo gracedo

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gracedo @coveralls @cwyl02