Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Open Telemetry for logging #3762

Merged
merged 20 commits into from
Dec 7, 2023
Merged

Switch to Open Telemetry for logging #3762

merged 20 commits into from
Dec 7, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Oct 24, 2023 •
edited
Loading

Resolves #3761

Switch to Open Telemetry logging and add variable to set logging level. Also updated the docs.

This makes troubleshooting issues much easier.

Custom attributes for operation_id:
image

Application map:
image

Fast API requests:
image

@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

Unit Test Results

582 tests   582 ✔️  6s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit bc0e0ad.

♻️ This comment has been updated with latest results.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 24, 2023
View reviewed changes
resource_processor/vmss_porter/runner.py Fixed Show fixed Hide fixed
resource_processor/vmss_porter/runner.py Fixed Show fixed Hide fixed
api_app/services/logging.py Fixed Show fixed Hide fixed
api_app/services/logging.py Fixed Show fixed Hide fixed
@marrobi marrobi marked this pull request as ready for review November 30, 2023 11:31
@marrobi
Copy link
Member Author

marrobi commented Nov 30, 2023

/test-extended

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7046329693 (with refid 838d26e6)

(in response to this comment from @marrobi)

@marrobi marrobi enabled auto-merge (squash) November 30, 2023 12:38
@marrobi marrobi mentioned this pull request Dec 6, 2023
Merged
@marrobi
Copy link
Member Author

marrobi commented Dec 7, 2023

/test-extended

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7129210899 (with refid 838d26e6)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Dec 7, 2023

/test-extended

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7129368946 (with refid 838d26e6)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit c382f3d into microsoft:main Dec 7, 2023
10 checks passed
@marrobi marrobi deleted the marrobi/issue3761 branch December 7, 2023 16:33
@marrobi
Copy link
Member Author

marrobi commented Dec 12, 2023

/test-destroy-env

@github-actions GitHub Actions
Copy link

Destroying PR test environment (RG: rg-tre838d26e6)... (run: https://github.com/microsoft/AzureTRE/actions/runs/7180419361)

@github-actions GitHub Actions
Copy link

PR test environment destroy complete (RG: rg-tre838d26e6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpeck martinpeck martinpeck approved these changes

@tamirkamara tamirkamara Awaiting requested review from tamirkamara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate to Open Telemetry for logging
2 participants
@marrobi @martinpeck