Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using managed identity for auth to CosmosDB. #3806

Merged
merged 35 commits into from
Jan 4, 2024

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Dec 6, 2023

Resolves #345

What is being addressed

Waiting on Logging PR #3762

  • Move to managed identity when connecting to the database when available.
  • Use same connect method for health checks.
  • Only attempt to create collection on bootstrap
  • Split out control plane and data plane operations as have different permissions model.
  • Create singleton database class to enable reuse of the cosmos client.
  • Update Change Log

Copy link

github-actions bot commented Dec 6, 2023

Unit Test Results

588 tests   588 ✅  7s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit c33d9db.

♻️ This comment has been updated with latest results.

@DragosDanielBoia
Copy link
Member

@microsoft-github-policy-service rerun

@marrobi marrobi marked this pull request as ready for review December 7, 2023 17:07
@marrobi
Copy link
Member Author

marrobi commented Dec 7, 2023

/test-extended

Copy link

github-actions bot commented Dec 7, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7131558096 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Dec 12, 2023

/test-destroy-env

Copy link

Destroying PR test environment (RG: rg-tre0a570b02)... (run: https://github.com/microsoft/AzureTRE/actions/runs/7180379175)

Copy link

PR test environment destroy complete (RG: rg-tre0a570b02)

@marrobi
Copy link
Member Author

marrobi commented Dec 20, 2023

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7275010888 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Dec 20, 2023

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7278921500 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Dec 21, 2023

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7287829909 (with refid 0a570b02)

(in response to this comment from @marrobi)

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7287829909 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Jan 2, 2024

/test-extended

Copy link

github-actions bot commented Jan 2, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7387658663 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Jan 2, 2024

/test-extended

Copy link

github-actions bot commented Jan 2, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7388101965 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Jan 2, 2024

/test-extended

Copy link

github-actions bot commented Jan 2, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7388651982 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Jan 3, 2024

/test-extended

Copy link

github-actions bot commented Jan 3, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7397685388 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Jan 3, 2024

/test-extended

Copy link

github-actions bot commented Jan 3, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7398222845 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Jan 3, 2024

/test-extended

Copy link

github-actions bot commented Jan 3, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7399589965 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Jan 3, 2024

/test-extended

Copy link

github-actions bot commented Jan 3, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7399691502 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Jan 3, 2024

/test-extended

Copy link

github-actions bot commented Jan 3, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7400155369 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi marrobi enabled auto-merge (squash) January 3, 2024 17:11
@marrobi
Copy link
Member Author

marrobi commented Jan 3, 2024

/test-extended

Copy link

github-actions bot commented Jan 3, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7403210335 (with refid 0a570b02)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 9c59b80 into microsoft:main Jan 4, 2024
10 checks passed
@marrobi marrobi deleted the marrobi/issue345 branch January 4, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] API to use Managed Identity to authenticate against Cosmos DB
3 participants