fix: Notification deep link #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
lei9444
previously requested changes
Nov 6, 2020
Composer/packages/client/src/pages/notifications/useNotifications.tsx
Outdated
Show resolved
Hide resolved
|
I think this is a quick fix now. In #4457 we will add sidebar to show the different bots' diagnostics, and move some states to selectorFamily |
|
LGTM |
boydc2014
approved these changes
Nov 6, 2020
GeoffCoxMSFT
added a commit
that referenced
this pull request
Nov 9, 2020
* Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * feat: update sdk package to 4.11.0-rc2 (#4625) * Update sdk package to 4.11.0-rc2 * Fix tests for ReplaceDialog * Delete the default appsettings that ships with qna (#4650) Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> * fix: dialog resources recognizer/qna incorrect creation (#4612) * fix customize imported dialog resource auto creation * add test * avoid touch form generated dialog * update detecting * update test * update detecting at server Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * larger warning icon (#4665) * fix: Test/Start buttons unable to click. (#4666) * filter hidden card, do not render empty container * update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish fail (#4660) Co-authored-by: Dong Lei <donglei@microsoft.com> * always show "create from scratch" button in "from url modal" (#4662) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: update 'Disable/Enable' buttons state in realtime (#4664) * add dialog content as a dep of useMemo #4629 * remove log Co-authored-by: Dong Lei <donglei@microsoft.com> * does not allow to delete root bot (#4671) * fix: Visual canvas mess up when add new actions in a zoom in/out mode (#4672) * fix: mess when zoom in/out * use scroll Co-authored-by: Dong Lei <donglei@microsoft.com> * use throttle 200 instead of debounce 1000 (#4670) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * promisify the 'saveData()' api and fix #4616 (#4667) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Form dialog hidden fixed feature flags (#4675) * Form dialog hidden fixed feature flags * remove temp lint directive * Removed debugging vars * don't install package during eject js runtime, install and build when publish (#4668) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> * fix: misordered using directives in runtime (#4684) * Update Startup.cs * Update runtime/dotnet/azurewebapp/Startup.cs * add region parameter to luis build call options (#4685) * change Microsoft.UpdateActivity title from "Send an activity" to "Update an activity" (#4686) Co-authored-by: Dong Lei <donglei@microsoft.com> * read recognizer intent from dialog content (#4683) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: router cache bug (#4687) * clean all router cache when switching project * reset routerCache * should check rootProjectId Co-authored-by: Dong Lei <donglei@microsoft.com> * Fix variable name (#4661) Co-authored-by: Dong Lei <donglei@microsoft.com> * feature: Supporting core+package templates stored on NuGet (#4588) * - added hosted template to template list - updated template type to account for hosted templates * initial scaffolding of hosted template grab * external nuget template working e2e as template in creation flow * Removing redundent types * adding support for relative runtime paths. Removing unused dependencies. * adding comments and removing autogenerated yan lock file from root dir * Adding version to template acquasition Generating build files Fixing broken unit test * updating template version to latest stable * hiding remote template feature flag until NuGet packages are public * Making PR changes * simplifying featureflag logic changing feature flag default values * removing bad null check * update naming * Fixing broken test updating locale files with latest added strings * Removing 'del' dependency in favor of rimraf for directory deletions * Reverting feature flag bug fix in favor for bug fix implemented in seperate PR Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: breadcrumb display for ProjectTree (#4604) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx * initialize onboarding status to complete in non-production * restore WelcomeModalCloseIcon to ToDoBot test Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Sorting OneOfField options / better default type (#4673) * Sorting OneOfField options based on type weights * Fix test * fix test Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> * Updated locale from building (#4694) * when changes on common.lg, reparse all lgFiles (#4669) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * Update projectTemplates.ts (#4697) * fix: undo/redo (#4688) * Bot proj breadcrumbs (#4) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: undo/redo * add location check and add fix unit tests * Revert "Bot proj breadcrumbs (#4)" This reverts commit d558846. * add selector for undo * move status * fix unit test Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Notification deep link (#4700) * notification with multi-bot, fix url * clean up * redirect to dialog root (#4698) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Update disabled property to booleanExpression across all the kinds + two uischema update (#4682) * Update disabled property to booleanExpression across all the kinds * Update server sdk schema and include other two uischema update * Revert "Update server sdk schema and include other two uischema update" This reverts commit cfffa74. * update server sdk schema and include two other uischema update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: the generated recognizer files is messy when the dialog name has the same prefix (#4708) * move luBuildResolver to shared lib, apply in azurePublish (#4709) Co-authored-by: Dong Lei <donglei@microsoft.com> * replace deprecated azure blob interface (#4702) Co-authored-by: Dong Lei <donglei@microsoft.com> * add useMemo to improve performance (#4701) Co-authored-by: Dong Lei <donglei@microsoft.com> * make name text field disable in edit (#4699) Co-authored-by: Dong Lei <donglei@microsoft.com> * ci: Disable CI validation (#4646) Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: remodel ProjectTree for greater clarity (#4714) * start tree CSS experiments * Update projectTemplates.ts * make ProjectTree save tree state * start possible fix for textwidth * Update ProjectTree.tsx * Update ProjectTree.tsx * no more squishy triangles * make left-right split view thing work * Update treeItem.tsx * Always enable allowClarmsValidator (#4717) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: undo/redo can't navigate to the correct position (#4722) * fix: undo/redo can't navigate to the correct position * update the type * fix: add skillConfiguration settings for old bot (#4724) * fix: add skillConfiguration settings for old bot * add update file for get Co-authored-by: Dong Lei <donglei@microsoft.com> * fix onResize handler props (#4720) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish failed (#4725) * fix: update incompatible Trigger redirect url & icon size (#4719) * fix onResize handler props * increase warning icon font size to 12 * fix incompatible trigger redirect url * Revert "fix onResize handler props" This reverts commit c9ba885. Co-authored-by: Dong Lei <donglei@microsoft.com> * feat: Integrate OneAuth library (#4677) * Integrated OneAuth library for Windows * Auth updates * chore: remove orchestrator (#4602) * Added CSRF protection to getAccessToken route. * Build changes to support OneAuth * Shared types and did some renaming. * Consolidated types * Fixed naming issue on babel localization config * Separated out auth service code. * Removed TODO * Updated shim to be at the oneauth service level * Added interactive retry when failing to get token silently * Added documentation for using OneAuth locally * sign mac assets with correct entitlements add mac signing script add signing and verifying steps fix path to bundles copy provision profile into each app bundle copy the provision profile in contents directory sign each dylib and framework version fix logging string sign frameworks before bundles * Made temporary mac auth flow dev-env-only * Fixed bad import * Removed manual oneauth installation steps from AUTH.md * Linting fixes * Setup tests * Added more tests * Added test for token caching. * Added cross-platform testing for oneauth service Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: zxyanliu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: liweitian <weitli@microsoft.com> Co-authored-by: Péter Bozsó <3806723+peterbozso@users.noreply.github.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Nov 11, 2020
* settingsPage: (53 commits) feat: Local Bots Start/Stop runtime (microsoft#4498) fix: Give a header to the enum fields (microsoft#4732) fix: Adding text when no visible feature flags are present (microsoft#4733) feat: Integrate OneAuth library (microsoft#4677) fix: update incompatible Trigger redirect url & icon size (microsoft#4719) fix: azure publish failed (microsoft#4725) fix onResize handler props (microsoft#4720) fix: add skillConfiguration settings for old bot (microsoft#4724) fix: undo/redo can't navigate to the correct position (microsoft#4722) Always enable allowClarmsValidator (microsoft#4717) fix: remodel ProjectTree for greater clarity (microsoft#4714) ci: Disable CI validation (microsoft#4646) make name text field disable in edit (microsoft#4699) add useMemo to improve performance (microsoft#4701) replace deprecated azure blob interface (microsoft#4702) move luBuildResolver to shared lib, apply in azurePublish (microsoft#4709) fix: the generated recognizer files is messy when the dialog name has the same prefix (microsoft#4708) fix: Update disabled property to booleanExpression across all the kinds + two uischema update (microsoft#4682) redirect to dialog root (microsoft#4698) fix: Notification deep link (microsoft#4700) ...
Merged
GeoffCoxMSFT
added a commit
that referenced
this pull request
Nov 17, 2020
* Excluded luconfig.json from project load (#4648) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * fix: Fixes dismissing a property card due to clicking outside of it during text selection inside the card. (#4649) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * Revert "Fix: form dialog view dialog action" This reverts commit eacbbd1. Co-authored-by: Soroush <sorgh@microsoft.com> * chore: sync form-dialogs feature branch (#4734) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * feat: update sdk package to 4.11.0-rc2 (#4625) * Update sdk package to 4.11.0-rc2 * Fix tests for ReplaceDialog * Delete the default appsettings that ships with qna (#4650) Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> * fix: dialog resources recognizer/qna incorrect creation (#4612) * fix customize imported dialog resource auto creation * add test * avoid touch form generated dialog * update detecting * update test * update detecting at server Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * larger warning icon (#4665) * fix: Test/Start buttons unable to click. (#4666) * filter hidden card, do not render empty container * update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish fail (#4660) Co-authored-by: Dong Lei <donglei@microsoft.com> * always show "create from scratch" button in "from url modal" (#4662) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: update 'Disable/Enable' buttons state in realtime (#4664) * add dialog content as a dep of useMemo #4629 * remove log Co-authored-by: Dong Lei <donglei@microsoft.com> * does not allow to delete root bot (#4671) * fix: Visual canvas mess up when add new actions in a zoom in/out mode (#4672) * fix: mess when zoom in/out * use scroll Co-authored-by: Dong Lei <donglei@microsoft.com> * use throttle 200 instead of debounce 1000 (#4670) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * promisify the 'saveData()' api and fix #4616 (#4667) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Form dialog hidden fixed feature flags (#4675) * Form dialog hidden fixed feature flags * remove temp lint directive * Removed debugging vars * don't install package during eject js runtime, install and build when publish (#4668) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> * fix: misordered using directives in runtime (#4684) * Update Startup.cs * Update runtime/dotnet/azurewebapp/Startup.cs * add region parameter to luis build call options (#4685) * change Microsoft.UpdateActivity title from "Send an activity" to "Update an activity" (#4686) Co-authored-by: Dong Lei <donglei@microsoft.com> * read recognizer intent from dialog content (#4683) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: router cache bug (#4687) * clean all router cache when switching project * reset routerCache * should check rootProjectId Co-authored-by: Dong Lei <donglei@microsoft.com> * Fix variable name (#4661) Co-authored-by: Dong Lei <donglei@microsoft.com> * feature: Supporting core+package templates stored on NuGet (#4588) * - added hosted template to template list - updated template type to account for hosted templates * initial scaffolding of hosted template grab * external nuget template working e2e as template in creation flow * Removing redundent types * adding support for relative runtime paths. Removing unused dependencies. * adding comments and removing autogenerated yan lock file from root dir * Adding version to template acquasition Generating build files Fixing broken unit test * updating template version to latest stable * hiding remote template feature flag until NuGet packages are public * Making PR changes * simplifying featureflag logic changing feature flag default values * removing bad null check * update naming * Fixing broken test updating locale files with latest added strings * Removing 'del' dependency in favor of rimraf for directory deletions * Reverting feature flag bug fix in favor for bug fix implemented in seperate PR Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: breadcrumb display for ProjectTree (#4604) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx * initialize onboarding status to complete in non-production * restore WelcomeModalCloseIcon to ToDoBot test Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Sorting OneOfField options / better default type (#4673) * Sorting OneOfField options based on type weights * Fix test * fix test Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> * Updated locale from building (#4694) * when changes on common.lg, reparse all lgFiles (#4669) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * Update projectTemplates.ts (#4697) * fix: undo/redo (#4688) * Bot proj breadcrumbs (#4) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: undo/redo * add location check and add fix unit tests * Revert "Bot proj breadcrumbs (#4)" This reverts commit d558846. * add selector for undo * move status * fix unit test Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Notification deep link (#4700) * notification with multi-bot, fix url * clean up * redirect to dialog root (#4698) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Update disabled property to booleanExpression across all the kinds + two uischema update (#4682) * Update disabled property to booleanExpression across all the kinds * Update server sdk schema and include other two uischema update * Revert "Update server sdk schema and include other two uischema update" This reverts commit cfffa74. * update server sdk schema and include two other uischema update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: the generated recognizer files is messy when the dialog name has the same prefix (#4708) * move luBuildResolver to shared lib, apply in azurePublish (#4709) Co-authored-by: Dong Lei <donglei@microsoft.com> * replace deprecated azure blob interface (#4702) Co-authored-by: Dong Lei <donglei@microsoft.com> * add useMemo to improve performance (#4701) Co-authored-by: Dong Lei <donglei@microsoft.com> * make name text field disable in edit (#4699) Co-authored-by: Dong Lei <donglei@microsoft.com> * ci: Disable CI validation (#4646) Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: remodel ProjectTree for greater clarity (#4714) * start tree CSS experiments * Update projectTemplates.ts * make ProjectTree save tree state * start possible fix for textwidth * Update ProjectTree.tsx * Update ProjectTree.tsx * no more squishy triangles * make left-right split view thing work * Update treeItem.tsx * Always enable allowClarmsValidator (#4717) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: undo/redo can't navigate to the correct position (#4722) * fix: undo/redo can't navigate to the correct position * update the type * fix: add skillConfiguration settings for old bot (#4724) * fix: add skillConfiguration settings for old bot * add update file for get Co-authored-by: Dong Lei <donglei@microsoft.com> * fix onResize handler props (#4720) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish failed (#4725) * fix: update incompatible Trigger redirect url & icon size (#4719) * fix onResize handler props * increase warning icon font size to 12 * fix incompatible trigger redirect url * Revert "fix onResize handler props" This reverts commit c9ba885. Co-authored-by: Dong Lei <donglei@microsoft.com> * feat: Integrate OneAuth library (#4677) * Integrated OneAuth library for Windows * Auth updates * chore: remove orchestrator (#4602) * Added CSRF protection to getAccessToken route. * Build changes to support OneAuth * Shared types and did some renaming. * Consolidated types * Fixed naming issue on babel localization config * Separated out auth service code. * Removed TODO * Updated shim to be at the oneauth service level * Added interactive retry when failing to get token silently * Added documentation for using OneAuth locally * sign mac assets with correct entitlements add mac signing script add signing and verifying steps fix path to bundles copy provision profile into each app bundle copy the provision profile in contents directory sign each dylib and framework version fix logging string sign frameworks before bundles * Made temporary mac auth flow dev-env-only * Fixed bad import * Removed manual oneauth installation steps from AUTH.md * Linting fixes * Setup tests * Added more tests * Added test for token caching. * Added cross-platform testing for oneauth service Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: zxyanliu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: liweitian <weitli@microsoft.com> Co-authored-by: Péter Bozsó <3806723+peterbozso@users.noreply.github.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * .form extension for form dialog schema files (#4735) Co-authored-by: Soroush <sorgh@microsoft.com> * Update library, show feature flag * Set app schema for generated dialogs (#4834) * Updated strings * undo old fix * revert yarn.lock changes * revert generate library update Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: zxyanliu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: liweitian <weitli@microsoft.com> Co-authored-by: Péter Bozsó <3806723+peterbozso@users.noreply.github.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
EricDahlvang
pushed a commit
that referenced
this pull request
Nov 27, 2020
* Excluded luconfig.json from project load (#4648) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * fix: Fixes dismissing a property card due to clicking outside of it during text selection inside the card. (#4649) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * Revert "Fix: form dialog view dialog action" This reverts commit eacbbd1. Co-authored-by: Soroush <sorgh@microsoft.com> * chore: sync form-dialogs feature branch (#4734) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * feat: update sdk package to 4.11.0-rc2 (#4625) * Update sdk package to 4.11.0-rc2 * Fix tests for ReplaceDialog * Delete the default appsettings that ships with qna (#4650) Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> * fix: dialog resources recognizer/qna incorrect creation (#4612) * fix customize imported dialog resource auto creation * add test * avoid touch form generated dialog * update detecting * update test * update detecting at server Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * larger warning icon (#4665) * fix: Test/Start buttons unable to click. (#4666) * filter hidden card, do not render empty container * update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish fail (#4660) Co-authored-by: Dong Lei <donglei@microsoft.com> * always show "create from scratch" button in "from url modal" (#4662) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: update 'Disable/Enable' buttons state in realtime (#4664) * add dialog content as a dep of useMemo #4629 * remove log Co-authored-by: Dong Lei <donglei@microsoft.com> * does not allow to delete root bot (#4671) * fix: Visual canvas mess up when add new actions in a zoom in/out mode (#4672) * fix: mess when zoom in/out * use scroll Co-authored-by: Dong Lei <donglei@microsoft.com> * use throttle 200 instead of debounce 1000 (#4670) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * promisify the 'saveData()' api and fix #4616 (#4667) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Form dialog hidden fixed feature flags (#4675) * Form dialog hidden fixed feature flags * remove temp lint directive * Removed debugging vars * don't install package during eject js runtime, install and build when publish (#4668) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> * fix: misordered using directives in runtime (#4684) * Update Startup.cs * Update runtime/dotnet/azurewebapp/Startup.cs * add region parameter to luis build call options (#4685) * change Microsoft.UpdateActivity title from "Send an activity" to "Update an activity" (#4686) Co-authored-by: Dong Lei <donglei@microsoft.com> * read recognizer intent from dialog content (#4683) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: router cache bug (#4687) * clean all router cache when switching project * reset routerCache * should check rootProjectId Co-authored-by: Dong Lei <donglei@microsoft.com> * Fix variable name (#4661) Co-authored-by: Dong Lei <donglei@microsoft.com> * feature: Supporting core+package templates stored on NuGet (#4588) * - added hosted template to template list - updated template type to account for hosted templates * initial scaffolding of hosted template grab * external nuget template working e2e as template in creation flow * Removing redundent types * adding support for relative runtime paths. Removing unused dependencies. * adding comments and removing autogenerated yan lock file from root dir * Adding version to template acquasition Generating build files Fixing broken unit test * updating template version to latest stable * hiding remote template feature flag until NuGet packages are public * Making PR changes * simplifying featureflag logic changing feature flag default values * removing bad null check * update naming * Fixing broken test updating locale files with latest added strings * Removing 'del' dependency in favor of rimraf for directory deletions * Reverting feature flag bug fix in favor for bug fix implemented in seperate PR Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: breadcrumb display for ProjectTree (#4604) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx * initialize onboarding status to complete in non-production * restore WelcomeModalCloseIcon to ToDoBot test Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Sorting OneOfField options / better default type (#4673) * Sorting OneOfField options based on type weights * Fix test * fix test Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> * Updated locale from building (#4694) * when changes on common.lg, reparse all lgFiles (#4669) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * Update projectTemplates.ts (#4697) * fix: undo/redo (#4688) * Bot proj breadcrumbs (#4) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: undo/redo * add location check and add fix unit tests * Revert "Bot proj breadcrumbs (#4)" This reverts commit d558846. * add selector for undo * move status * fix unit test Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Notification deep link (#4700) * notification with multi-bot, fix url * clean up * redirect to dialog root (#4698) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Update disabled property to booleanExpression across all the kinds + two uischema update (#4682) * Update disabled property to booleanExpression across all the kinds * Update server sdk schema and include other two uischema update * Revert "Update server sdk schema and include other two uischema update" This reverts commit cfffa74. * update server sdk schema and include two other uischema update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: the generated recognizer files is messy when the dialog name has the same prefix (#4708) * move luBuildResolver to shared lib, apply in azurePublish (#4709) Co-authored-by: Dong Lei <donglei@microsoft.com> * replace deprecated azure blob interface (#4702) Co-authored-by: Dong Lei <donglei@microsoft.com> * add useMemo to improve performance (#4701) Co-authored-by: Dong Lei <donglei@microsoft.com> * make name text field disable in edit (#4699) Co-authored-by: Dong Lei <donglei@microsoft.com> * ci: Disable CI validation (#4646) Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: remodel ProjectTree for greater clarity (#4714) * start tree CSS experiments * Update projectTemplates.ts * make ProjectTree save tree state * start possible fix for textwidth * Update ProjectTree.tsx * Update ProjectTree.tsx * no more squishy triangles * make left-right split view thing work * Update treeItem.tsx * Always enable allowClarmsValidator (#4717) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: undo/redo can't navigate to the correct position (#4722) * fix: undo/redo can't navigate to the correct position * update the type * fix: add skillConfiguration settings for old bot (#4724) * fix: add skillConfiguration settings for old bot * add update file for get Co-authored-by: Dong Lei <donglei@microsoft.com> * fix onResize handler props (#4720) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish failed (#4725) * fix: update incompatible Trigger redirect url & icon size (#4719) * fix onResize handler props * increase warning icon font size to 12 * fix incompatible trigger redirect url * Revert "fix onResize handler props" This reverts commit c9ba885. Co-authored-by: Dong Lei <donglei@microsoft.com> * feat: Integrate OneAuth library (#4677) * Integrated OneAuth library for Windows * Auth updates * chore: remove orchestrator (#4602) * Added CSRF protection to getAccessToken route. * Build changes to support OneAuth * Shared types and did some renaming. * Consolidated types * Fixed naming issue on babel localization config * Separated out auth service code. * Removed TODO * Updated shim to be at the oneauth service level * Added interactive retry when failing to get token silently * Added documentation for using OneAuth locally * sign mac assets with correct entitlements add mac signing script add signing and verifying steps fix path to bundles copy provision profile into each app bundle copy the provision profile in contents directory sign each dylib and framework version fix logging string sign frameworks before bundles * Made temporary mac auth flow dev-env-only * Fixed bad import * Removed manual oneauth installation steps from AUTH.md * Linting fixes * Setup tests * Added more tests * Added test for token caching. * Added cross-platform testing for oneauth service Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: zxyanliu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: liweitian <weitli@microsoft.com> Co-authored-by: Péter Bozsó <3806723+peterbozso@users.noreply.github.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * .form extension for form dialog schema files (#4735) Co-authored-by: Soroush <sorgh@microsoft.com> * Update library, show feature flag * Set app schema for generated dialogs (#4834) * Updated strings * undo old fix * revert yarn.lock changes * revert generate library update Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: zxyanliu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: liweitian <weitli@microsoft.com> Co-authored-by: Péter Bozsó <3806723+peterbozso@users.noreply.github.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* Excluded luconfig.json from project load (microsoft#4648) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * fix: Fixes dismissing a property card due to clicking outside of it during text selection inside the card. (microsoft#4649) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * Revert "Fix: form dialog view dialog action" This reverts commit eacbbd1. Co-authored-by: Soroush <sorgh@microsoft.com> * chore: sync form-dialogs feature branch (microsoft#4734) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * feat: update sdk package to 4.11.0-rc2 (microsoft#4625) * Update sdk package to 4.11.0-rc2 * Fix tests for ReplaceDialog * Delete the default appsettings that ships with qna (microsoft#4650) Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> * fix: dialog resources recognizer/qna incorrect creation (microsoft#4612) * fix customize imported dialog resource auto creation * add test * avoid touch form generated dialog * update detecting * update test * update detecting at server Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * larger warning icon (microsoft#4665) * fix: Test/Start buttons unable to click. (microsoft#4666) * filter hidden card, do not render empty container * update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish fail (microsoft#4660) Co-authored-by: Dong Lei <donglei@microsoft.com> * always show "create from scratch" button in "from url modal" (microsoft#4662) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: update 'Disable/Enable' buttons state in realtime (microsoft#4664) * add dialog content as a dep of useMemo microsoft#4629 * remove log Co-authored-by: Dong Lei <donglei@microsoft.com> * does not allow to delete root bot (microsoft#4671) * fix: Visual canvas mess up when add new actions in a zoom in/out mode (microsoft#4672) * fix: mess when zoom in/out * use scroll Co-authored-by: Dong Lei <donglei@microsoft.com> * use throttle 200 instead of debounce 1000 (microsoft#4670) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * promisify the 'saveData()' api and fix microsoft#4616 (microsoft#4667) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Form dialog hidden fixed feature flags (microsoft#4675) * Form dialog hidden fixed feature flags * remove temp lint directive * Removed debugging vars * don't install package during eject js runtime, install and build when publish (microsoft#4668) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> * fix: misordered using directives in runtime (microsoft#4684) * Update Startup.cs * Update runtime/dotnet/azurewebapp/Startup.cs * add region parameter to luis build call options (microsoft#4685) * change Microsoft.UpdateActivity title from "Send an activity" to "Update an activity" (microsoft#4686) Co-authored-by: Dong Lei <donglei@microsoft.com> * read recognizer intent from dialog content (microsoft#4683) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: router cache bug (microsoft#4687) * clean all router cache when switching project * reset routerCache * should check rootProjectId Co-authored-by: Dong Lei <donglei@microsoft.com> * Fix variable name (microsoft#4661) Co-authored-by: Dong Lei <donglei@microsoft.com> * feature: Supporting core+package templates stored on NuGet (microsoft#4588) * - added hosted template to template list - updated template type to account for hosted templates * initial scaffolding of hosted template grab * external nuget template working e2e as template in creation flow * Removing redundent types * adding support for relative runtime paths. Removing unused dependencies. * adding comments and removing autogenerated yan lock file from root dir * Adding version to template acquasition Generating build files Fixing broken unit test * updating template version to latest stable * hiding remote template feature flag until NuGet packages are public * Making PR changes * simplifying featureflag logic changing feature flag default values * removing bad null check * update naming * Fixing broken test updating locale files with latest added strings * Removing 'del' dependency in favor of rimraf for directory deletions * Reverting feature flag bug fix in favor for bug fix implemented in seperate PR Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: breadcrumb display for ProjectTree (microsoft#4604) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx * initialize onboarding status to complete in non-production * restore WelcomeModalCloseIcon to ToDoBot test Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Sorting OneOfField options / better default type (microsoft#4673) * Sorting OneOfField options based on type weights * Fix test * fix test Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> * Updated locale from building (microsoft#4694) * when changes on common.lg, reparse all lgFiles (microsoft#4669) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * Update projectTemplates.ts (microsoft#4697) * fix: undo/redo (microsoft#4688) * Bot proj breadcrumbs (microsoft#4) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: undo/redo * add location check and add fix unit tests * Revert "Bot proj breadcrumbs (microsoft#4)" This reverts commit d558846. * add selector for undo * move status * fix unit test Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Notification deep link (microsoft#4700) * notification with multi-bot, fix url * clean up * redirect to dialog root (microsoft#4698) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Update disabled property to booleanExpression across all the kinds + two uischema update (microsoft#4682) * Update disabled property to booleanExpression across all the kinds * Update server sdk schema and include other two uischema update * Revert "Update server sdk schema and include other two uischema update" This reverts commit cfffa74. * update server sdk schema and include two other uischema update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: the generated recognizer files is messy when the dialog name has the same prefix (microsoft#4708) * move luBuildResolver to shared lib, apply in azurePublish (microsoft#4709) Co-authored-by: Dong Lei <donglei@microsoft.com> * replace deprecated azure blob interface (microsoft#4702) Co-authored-by: Dong Lei <donglei@microsoft.com> * add useMemo to improve performance (microsoft#4701) Co-authored-by: Dong Lei <donglei@microsoft.com> * make name text field disable in edit (microsoft#4699) Co-authored-by: Dong Lei <donglei@microsoft.com> * ci: Disable CI validation (microsoft#4646) Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: remodel ProjectTree for greater clarity (microsoft#4714) * start tree CSS experiments * Update projectTemplates.ts * make ProjectTree save tree state * start possible fix for textwidth * Update ProjectTree.tsx * Update ProjectTree.tsx * no more squishy triangles * make left-right split view thing work * Update treeItem.tsx * Always enable allowClarmsValidator (microsoft#4717) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: undo/redo can't navigate to the correct position (microsoft#4722) * fix: undo/redo can't navigate to the correct position * update the type * fix: add skillConfiguration settings for old bot (microsoft#4724) * fix: add skillConfiguration settings for old bot * add update file for get Co-authored-by: Dong Lei <donglei@microsoft.com> * fix onResize handler props (microsoft#4720) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish failed (microsoft#4725) * fix: update incompatible Trigger redirect url & icon size (microsoft#4719) * fix onResize handler props * increase warning icon font size to 12 * fix incompatible trigger redirect url * Revert "fix onResize handler props" This reverts commit c9ba885. Co-authored-by: Dong Lei <donglei@microsoft.com> * feat: Integrate OneAuth library (microsoft#4677) * Integrated OneAuth library for Windows * Auth updates * chore: remove orchestrator (microsoft#4602) * Added CSRF protection to getAccessToken route. * Build changes to support OneAuth * Shared types and did some renaming. * Consolidated types * Fixed naming issue on babel localization config * Separated out auth service code. * Removed TODO * Updated shim to be at the oneauth service level * Added interactive retry when failing to get token silently * Added documentation for using OneAuth locally * sign mac assets with correct entitlements add mac signing script add signing and verifying steps fix path to bundles copy provision profile into each app bundle copy the provision profile in contents directory sign each dylib and framework version fix logging string sign frameworks before bundles * Made temporary mac auth flow dev-env-only * Fixed bad import * Removed manual oneauth installation steps from AUTH.md * Linting fixes * Setup tests * Added more tests * Added test for token caching. * Added cross-platform testing for oneauth service Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: zxyanliu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: liweitian <weitli@microsoft.com> Co-authored-by: Péter Bozsó <3806723+peterbozso@users.noreply.github.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * .form extension for form dialog schema files (microsoft#4735) Co-authored-by: Soroush <sorgh@microsoft.com> * Update library, show feature flag * Set app schema for generated dialogs (microsoft#4834) * Updated strings * undo old fix * revert yarn.lock changes * revert generate library update Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: zxyanliu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: liweitian <weitli@microsoft.com> Co-authored-by: Péter Bozsó <3806723+peterbozso@users.noreply.github.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * feat: update sdk package to 4.11.0-rc2 (microsoft#4625) * Update sdk package to 4.11.0-rc2 * Fix tests for ReplaceDialog * Delete the default appsettings that ships with qna (microsoft#4650) Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> * fix: dialog resources recognizer/qna incorrect creation (microsoft#4612) * fix customize imported dialog resource auto creation * add test * avoid touch form generated dialog * update detecting * update test * update detecting at server Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * larger warning icon (microsoft#4665) * fix: Test/Start buttons unable to click. (microsoft#4666) * filter hidden card, do not render empty container * update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish fail (microsoft#4660) Co-authored-by: Dong Lei <donglei@microsoft.com> * always show "create from scratch" button in "from url modal" (microsoft#4662) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: update 'Disable/Enable' buttons state in realtime (microsoft#4664) * add dialog content as a dep of useMemo microsoft#4629 * remove log Co-authored-by: Dong Lei <donglei@microsoft.com> * does not allow to delete root bot (microsoft#4671) * fix: Visual canvas mess up when add new actions in a zoom in/out mode (microsoft#4672) * fix: mess when zoom in/out * use scroll Co-authored-by: Dong Lei <donglei@microsoft.com> * use throttle 200 instead of debounce 1000 (microsoft#4670) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * promisify the 'saveData()' api and fix microsoft#4616 (microsoft#4667) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Form dialog hidden fixed feature flags (microsoft#4675) * Form dialog hidden fixed feature flags * remove temp lint directive * Removed debugging vars * don't install package during eject js runtime, install and build when publish (microsoft#4668) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> * fix: misordered using directives in runtime (microsoft#4684) * Update Startup.cs * Update runtime/dotnet/azurewebapp/Startup.cs * add region parameter to luis build call options (microsoft#4685) * change Microsoft.UpdateActivity title from "Send an activity" to "Update an activity" (microsoft#4686) Co-authored-by: Dong Lei <donglei@microsoft.com> * read recognizer intent from dialog content (microsoft#4683) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: router cache bug (microsoft#4687) * clean all router cache when switching project * reset routerCache * should check rootProjectId Co-authored-by: Dong Lei <donglei@microsoft.com> * Fix variable name (microsoft#4661) Co-authored-by: Dong Lei <donglei@microsoft.com> * feature: Supporting core+package templates stored on NuGet (microsoft#4588) * - added hosted template to template list - updated template type to account for hosted templates * initial scaffolding of hosted template grab * external nuget template working e2e as template in creation flow * Removing redundent types * adding support for relative runtime paths. Removing unused dependencies. * adding comments and removing autogenerated yan lock file from root dir * Adding version to template acquasition Generating build files Fixing broken unit test * updating template version to latest stable * hiding remote template feature flag until NuGet packages are public * Making PR changes * simplifying featureflag logic changing feature flag default values * removing bad null check * update naming * Fixing broken test updating locale files with latest added strings * Removing 'del' dependency in favor of rimraf for directory deletions * Reverting feature flag bug fix in favor for bug fix implemented in seperate PR Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: breadcrumb display for ProjectTree (microsoft#4604) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx * initialize onboarding status to complete in non-production * restore WelcomeModalCloseIcon to ToDoBot test Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Sorting OneOfField options / better default type (microsoft#4673) * Sorting OneOfField options based on type weights * Fix test * fix test Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> * Updated locale from building (microsoft#4694) * when changes on common.lg, reparse all lgFiles (microsoft#4669) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * Update projectTemplates.ts (microsoft#4697) * fix: undo/redo (microsoft#4688) * Bot proj breadcrumbs (microsoft#4) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: undo/redo * add location check and add fix unit tests * Revert "Bot proj breadcrumbs (microsoft#4)" This reverts commit d558846. * add selector for undo * move status * fix unit test Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Notification deep link (microsoft#4700) * notification with multi-bot, fix url * clean up * redirect to dialog root (microsoft#4698) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Update disabled property to booleanExpression across all the kinds + two uischema update (microsoft#4682) * Update disabled property to booleanExpression across all the kinds * Update server sdk schema and include other two uischema update * Revert "Update server sdk schema and include other two uischema update" This reverts commit cfffa74. * update server sdk schema and include two other uischema update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: the generated recognizer files is messy when the dialog name has the same prefix (microsoft#4708) * move luBuildResolver to shared lib, apply in azurePublish (microsoft#4709) Co-authored-by: Dong Lei <donglei@microsoft.com> * replace deprecated azure blob interface (microsoft#4702) Co-authored-by: Dong Lei <donglei@microsoft.com> * add useMemo to improve performance (microsoft#4701) Co-authored-by: Dong Lei <donglei@microsoft.com> * make name text field disable in edit (microsoft#4699) Co-authored-by: Dong Lei <donglei@microsoft.com> * ci: Disable CI validation (microsoft#4646) Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: remodel ProjectTree for greater clarity (microsoft#4714) * start tree CSS experiments * Update projectTemplates.ts * make ProjectTree save tree state * start possible fix for textwidth * Update ProjectTree.tsx * Update ProjectTree.tsx * no more squishy triangles * make left-right split view thing work * Update treeItem.tsx * Always enable allowClarmsValidator (microsoft#4717) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: undo/redo can't navigate to the correct position (microsoft#4722) * fix: undo/redo can't navigate to the correct position * update the type * fix: add skillConfiguration settings for old bot (microsoft#4724) * fix: add skillConfiguration settings for old bot * add update file for get Co-authored-by: Dong Lei <donglei@microsoft.com> * fix onResize handler props (microsoft#4720) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish failed (microsoft#4725) * fix: update incompatible Trigger redirect url & icon size (microsoft#4719) * fix onResize handler props * increase warning icon font size to 12 * fix incompatible trigger redirect url * Revert "fix onResize handler props" This reverts commit c9ba885. Co-authored-by: Dong Lei <donglei@microsoft.com> * feat: Integrate OneAuth library (microsoft#4677) * Integrated OneAuth library for Windows * Auth updates * chore: remove orchestrator (microsoft#4602) * Added CSRF protection to getAccessToken route. * Build changes to support OneAuth * Shared types and did some renaming. * Consolidated types * Fixed naming issue on babel localization config * Separated out auth service code. * Removed TODO * Updated shim to be at the oneauth service level * Added interactive retry when failing to get token silently * Added documentation for using OneAuth locally * sign mac assets with correct entitlements add mac signing script add signing and verifying steps fix path to bundles copy provision profile into each app bundle copy the provision profile in contents directory sign each dylib and framework version fix logging string sign frameworks before bundles * Made temporary mac auth flow dev-env-only * Fixed bad import * Removed manual oneauth installation steps from AUTH.md * Linting fixes * Setup tests * Added more tests * Added test for token caching. * Added cross-platform testing for oneauth service Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: zxyanliu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: liweitian <weitli@microsoft.com> Co-authored-by: Péter Bozsó <3806723+peterbozso@users.noreply.github.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* Excluded luconfig.json from project load (#4648) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * fix: Fixes dismissing a property card due to clicking outside of it during text selection inside the card. (#4649) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * Revert "Fix: form dialog view dialog action" This reverts commit 7eb5c35b715ccc73c3d3738555af994432e4bf58. Co-authored-by: Soroush <sorgh@microsoft.com> * chore: sync form-dialogs feature branch (#4734) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * feat: update sdk package to 4.11.0-rc2 (#4625) * Update sdk package to 4.11.0-rc2 * Fix tests for ReplaceDialog * Delete the default appsettings that ships with qna (#4650) Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> * fix: dialog resources recognizer/qna incorrect creation (#4612) * fix customize imported dialog resource auto creation * add test * avoid touch form generated dialog * update detecting * update test * update detecting at server Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * larger warning icon (#4665) * fix: Test/Start buttons unable to click. (#4666) * filter hidden card, do not render empty container * update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish fail (#4660) Co-authored-by: Dong Lei <donglei@microsoft.com> * always show "create from scratch" button in "from url modal" (#4662) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: update 'Disable/Enable' buttons state in realtime (#4664) * add dialog content as a dep of useMemo #4629 * remove log Co-authored-by: Dong Lei <donglei@microsoft.com> * does not allow to delete root bot (#4671) * fix: Visual canvas mess up when add new actions in a zoom in/out mode (#4672) * fix: mess when zoom in/out * use scroll Co-authored-by: Dong Lei <donglei@microsoft.com> * use throttle 200 instead of debounce 1000 (#4670) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * promisify the 'saveData()' api and fix #4616 (#4667) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Form dialog hidden fixed feature flags (#4675) * Form dialog hidden fixed feature flags * remove temp lint directive * Removed debugging vars * don't install package during eject js runtime, install and build when publish (#4668) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> * fix: misordered using directives in runtime (#4684) * Update Startup.cs * Update runtime/dotnet/azurewebapp/Startup.cs * add region parameter to luis build call options (#4685) * change Microsoft.UpdateActivity title from "Send an activity" to "Update an activity" (#4686) Co-authored-by: Dong Lei <donglei@microsoft.com> * read recognizer intent from dialog content (#4683) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: router cache bug (#4687) * clean all router cache when switching project * reset routerCache * should check rootProjectId Co-authored-by: Dong Lei <donglei@microsoft.com> * Fix variable name (#4661) Co-authored-by: Dong Lei <donglei@microsoft.com> * feature: Supporting core+package templates stored on NuGet (#4588) * - added hosted template to template list - updated template type to account for hosted templates * initial scaffolding of hosted template grab * external nuget template working e2e as template in creation flow * Removing redundent types * adding support for relative runtime paths. Removing unused dependencies. * adding comments and removing autogenerated yan lock file from root dir * Adding version to template acquasition Generating build files Fixing broken unit test * updating template version to latest stable * hiding remote template feature flag until NuGet packages are public * Making PR changes * simplifying featureflag logic changing feature flag default values * removing bad null check * update naming * Fixing broken test updating locale files with latest added strings * Removing 'del' dependency in favor of rimraf for directory deletions * Reverting feature flag bug fix in favor for bug fix implemented in seperate PR Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: breadcrumb display for ProjectTree (#4604) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx * initialize onboarding status to complete in non-production * restore WelcomeModalCloseIcon to ToDoBot test Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Sorting OneOfField options / better default type (#4673) * Sorting OneOfField options based on type weights * Fix test * fix test Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> * Updated locale from building (#4694) * when changes on common.lg, reparse all lgFiles (#4669) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * Update projectTemplates.ts (#4697) * fix: undo/redo (#4688) * Bot proj breadcrumbs (#4) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: undo/redo * add location check and add fix unit tests * Revert "Bot proj breadcrumbs (#4)" This reverts commit 9a846eaf5c68e2ca2762e7b8938d9ce81d2947d3. * add selector for undo * move status * fix unit test Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Notification deep link (#4700) * notification with multi-bot, fix url * clean up * redirect to dialog root (#4698) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Update disabled property to booleanExpression across all the kinds + two uischema update (#4682) * Update disabled property to booleanExpression across all the kinds * Update server sdk schema and include other two uischema update * Revert "Update server sdk schema and include other two uischema update" This reverts commit e0a6b4df9a824fba1d669ad8a099bf50614a26c1. * update server sdk schema and include two other uischema update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: the generated recognizer files is messy when the dialog name has the same prefix (#4708) * move luBuildResolver to shared lib, apply in azurePublish (#4709) Co-authored-by: Dong Lei <donglei@microsoft.com> * replace deprecated azure blob interface (#4702) Co-authored-by: Dong Lei <donglei@microsoft.com> * add useMemo to improve performance (#4701) Co-authored-by: Dong Lei <donglei@microsoft.com> * make name text field disable in edit (#4699) Co-authored-by: Dong Lei <donglei@microsoft.com> * ci: Disable CI validation (#4646) Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: remodel ProjectTree for greater clarity (#4714) * start tree CSS experiments * Update projectTemplates.ts * make ProjectTree save tree state * start possible fix for textwidth * Update ProjectTree.tsx * Update ProjectTree.tsx * no more squishy triangles * make left-right split view thing work * Update treeItem.tsx * Always enable allowClarmsValidator (#4717) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: undo/redo can't navigate to the correct position (#4722) * fix: undo/redo can't navigate to the correct position * update the type * fix: add skillConfiguration settings for old bot (#4724) * fix: add skillConfiguration settings for old bot * add update file for get Co-authored-by: Dong Lei <donglei@microsoft.com> * fix onResize handler props (#4720) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish failed (#4725) * fix: update incompatible Trigger redirect url & icon size (#4719) * fix onResize handler props * increase warning icon font size to 12 * fix incompatible trigger redirect url * Revert "fix onResize handler props" This reverts commit bad68c4d2403f0b5b1d3f04d1e6bfbc4952fda15. Co-authored-by: Dong Lei <donglei@microsoft.com> * feat: Integrate OneAuth library (#4677) * Integrated OneAuth library for Windows * Auth updates * chore: remove orchestrator (#4602) * Added CSRF protection to getAccessToken route. * Build changes to support OneAuth * Shared types and did some renaming. * Consolidated types * Fixed naming issue on babel localization config * Separated out auth service code. * Removed TODO * Updated shim to be at the oneauth service level * Added interactive retry when failing to get token silently * Added documentation for using OneAuth locally * sign mac assets with correct entitlements add mac signing script add signing and verifying steps fix path to bundles copy provision profile into each app bundle copy the provision profile in contents directory sign each dylib and framework version fix logging string sign frameworks before bundles * Made temporary mac auth flow dev-env-only * Fixed bad import * Removed manual oneauth installation steps from AUTH.md * Linting fixes * Setup tests * Added more tests * Added test for token caching. * Added cross-platform testing for oneauth service Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: zxyanliu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: liweitian <weitli@microsoft.com> Co-authored-by: Péter Bozsó <3806723+peterbozso@users.noreply.github.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * .form extension for form dialog schema files (#4735) Co-authored-by: Soroush <sorgh@microsoft.com> * Update library, show feature flag * Set app schema for generated dialogs (#4834) * Updated strings * undo old fix * revert yarn.lock changes * revert generate library update Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: zxyanliu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: liweitian <weitli@microsoft.com> Co-authored-by: Péter Bozsó <3806723+peterbozso@users.noreply.github.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* notification with multi-bot, fix url * clean up
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Excluded luconfig.json from project load (microsoft#4648) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * fix: Fixes dismissing a property card due to clicking outside of it during text selection inside the card. (microsoft#4649) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * Revert "Fix: form dialog view dialog action" This reverts commit 7eb5c35b715ccc73c3d3738555af994432e4bf58. Co-authored-by: Soroush <sorgh@microsoft.com> * chore: sync form-dialogs feature branch (microsoft#4734) * Fix: form dialog view dialog action * Fix: Prevent dismissing a property card due to click during text selection within the card * feat: update sdk package to 4.11.0-rc2 (microsoft#4625) * Update sdk package to 4.11.0-rc2 * Fix tests for ReplaceDialog * Delete the default appsettings that ships with qna (microsoft#4650) Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> * fix: dialog resources recognizer/qna incorrect creation (microsoft#4612) * fix customize imported dialog resource auto creation * add test * avoid touch form generated dialog * update detecting * update test * update detecting at server Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * larger warning icon (microsoft#4665) * fix: Test/Start buttons unable to click. (microsoft#4666) * filter hidden card, do not render empty container * update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish fail (microsoft#4660) Co-authored-by: Dong Lei <donglei@microsoft.com> * always show "create from scratch" button in "from url modal" (microsoft#4662) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: update 'Disable/Enable' buttons state in realtime (microsoft#4664) * add dialog content as a dep of useMemo microsoft#4629 * remove log Co-authored-by: Dong Lei <donglei@microsoft.com> * does not allow to delete root bot (microsoft#4671) * fix: Visual canvas mess up when add new actions in a zoom in/out mode (microsoft#4672) * fix: mess when zoom in/out * use scroll Co-authored-by: Dong Lei <donglei@microsoft.com> * use throttle 200 instead of debounce 1000 (microsoft#4670) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * promisify the 'saveData()' api and fix microsoft#4616 (microsoft#4667) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Form dialog hidden fixed feature flags (microsoft#4675) * Form dialog hidden fixed feature flags * remove temp lint directive * Removed debugging vars * don't install package during eject js runtime, install and build when publish (microsoft#4668) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> * fix: misordered using directives in runtime (microsoft#4684) * Update Startup.cs * Update runtime/dotnet/azurewebapp/Startup.cs * add region parameter to luis build call options (microsoft#4685) * change Microsoft.UpdateActivity title from "Send an activity" to "Update an activity" (microsoft#4686) Co-authored-by: Dong Lei <donglei@microsoft.com> * read recognizer intent from dialog content (microsoft#4683) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: router cache bug (microsoft#4687) * clean all router cache when switching project * reset routerCache * should check rootProjectId Co-authored-by: Dong Lei <donglei@microsoft.com> * Fix variable name (microsoft#4661) Co-authored-by: Dong Lei <donglei@microsoft.com> * feature: Supporting core+package templates stored on NuGet (microsoft#4588) * - added hosted template to template list - updated template type to account for hosted templates * initial scaffolding of hosted template grab * external nuget template working e2e as template in creation flow * Removing redundent types * adding support for relative runtime paths. Removing unused dependencies. * adding comments and removing autogenerated yan lock file from root dir * Adding version to template acquasition Generating build files Fixing broken unit test * updating template version to latest stable * hiding remote template feature flag until NuGet packages are public * Making PR changes * simplifying featureflag logic changing feature flag default values * removing bad null check * update naming * Fixing broken test updating locale files with latest added strings * Removing 'del' dependency in favor of rimraf for directory deletions * Reverting feature flag bug fix in favor for bug fix implemented in seperate PR Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: breadcrumb display for ProjectTree (microsoft#4604) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx * initialize onboarding status to complete in non-production * restore WelcomeModalCloseIcon to ToDoBot test Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: Sorting OneOfField options / better default type (microsoft#4673) * Sorting OneOfField options based on type weights * Fix test * fix test Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> * Updated locale from building (microsoft#4694) * when changes on common.lg, reparse all lgFiles (microsoft#4669) Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * Update projectTemplates.ts (microsoft#4697) * fix: undo/redo (microsoft#4688) * Bot proj breadcrumbs (#4) * remove old breadcrumbs and start making new ones * Update DesignPage.tsx * Update DesignPage.tsx * update unit tests to remove breadcrumb things * fix duplicate key bug in breadcrumbs * fix e2e test * detect and display action names in breadcrumb * rewrite to make typechecker happy * make new DesignPage unit tests * Update publisher.ts * Update publisher.ts * restore navigation in undo * retrieve breadcrumb from URL on location change * read double-nested $designer fields * navigate to trigger[0] on OpenDialog node events * fix typo and unit tests * Update validateDialogName.test.ts * better error-checking for invalid URLs * make special "beginDialog" trigger * Update en-US.json * Update DesignPage.tsx Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: undo/redo * add location check and add fix unit tests * Revert "Bot proj breadcrumbs (#4)" This reverts commit 9a846eaf5c68e2ca2762e7b8938d9ce81d2947d3. * add selector for undo * move status * fix unit test Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Notification deep link (microsoft#4700) * notification with multi-bot, fix url * clean up * redirect to dialog root (microsoft#4698) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: Update disabled property to booleanExpression across all the kinds + two uischema update (microsoft#4682) * Update disabled property to booleanExpression across all the kinds * Update server sdk schema and include other two uischema update * Revert "Update server sdk schema and include other two uischema update" This reverts commit e0a6b4df9a824fba1d669ad8a099bf50614a26c1. * update server sdk schema and include two other uischema update Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: the generated recognizer files is messy when the dialog name has the same prefix (microsoft#4708) * move luBuildResolver to shared lib, apply in azurePublish (microsoft#4709) Co-authored-by: Dong Lei <donglei@microsoft.com> * replace deprecated azure blob interface (microsoft#4702) Co-authored-by: Dong Lei <donglei@microsoft.com> * add useMemo to improve performance (microsoft#4701) Co-authored-by: Dong Lei <donglei@microsoft.com> * make name text field disable in edit (microsoft#4699) Co-authored-by: Dong Lei <donglei@microsoft.com> * ci: Disable CI validation (microsoft#4646) Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix: remodel ProjectTree for greater clarity (microsoft#4714) * start tree CSS experiments * Update projectTemplates.ts * make ProjectTree save tree state * start possible fix for textwidth * Update ProjectTree.tsx * Update ProjectTree.tsx * no more squishy triangles * make left-right split view thing work * Update treeItem.tsx * Always enable allowClarmsValidator (microsoft#4717) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: undo/redo can't navigate to the correct position (microsoft#4722) * fix: undo/redo can't navigate to the correct position * update the type * fix: add skillConfiguration settings for old bot (microsoft#4724) * fix: add skillConfiguration settings for old bot * add update file for get Co-authored-by: Dong Lei <donglei@microsoft.com> * fix onResize handler props (microsoft#4720) Co-authored-by: Dong Lei <donglei@microsoft.com> * fix: azure publish failed (microsoft#4725) * fix: update incompatible Trigger redirect url & icon size (microsoft#4719) * fix onResize handler props * increase warning icon font size to 12 * fix incompatible trigger redirect url * Revert "fix onResize handler props" This reverts commit bad68c4d2403f0b5b1d3f04d1e6bfbc4952fda15. Co-authored-by: Dong Lei <donglei@microsoft.com> * feat: Integrate OneAuth library (microsoft#4677) * Integrated OneAuth library for Windows * Auth updates * chore: remove orchestrator (microsoft#4602) * Added CSRF protection to getAccessToken route. * Build changes to support OneAuth * Shared types and did some renaming. * Consolidated types * Fixed naming issue on babel localization config * Separated out auth service code. * Removed TODO * Updated shim to be at the oneauth service level * Added interactive retry when failing to get token silently * Added documentation for using OneAuth locally * sign mac assets with correct entitlements add mac signing script add signing and verifying steps fix path to bundles copy provision profile into each app bundle copy the provision profile in contents directory sign each dylib and framework version fix logging string sign frameworks before bundles * Made temporary mac auth flow dev-env-only * Fixed bad import * Removed manual oneauth installation steps from AUTH.md * Linting fixes * Setup tests * Added more tests * Added test for token caching. * Added cross-platform testing for oneauth service Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: zxyanliu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: liweitian <weitli@microsoft.com> Co-authored-by: Péter Bozsó <3806723+peterbozso@users.noreply.github.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> * .form extension for form dialog schema files (microsoft#4735) Co-authored-by: Soroush <sorgh@microsoft.com> * Update library, show feature flag * Set app schema for generated dialogs (microsoft#4834) * Updated strings * undo old fix * revert yarn.lock changes * revert generate library update Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: VanyLaw <wenyluo@microsoft.com> Co-authored-by: zxyanliu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: liweitian <weitli@microsoft.com> Co-authored-by: Péter Bozsó <3806723+peterbozso@users.noreply.github.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com> Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Tony Anziano <tonyanziano5@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task Item
close #4638
Screenshots