Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding text when no visible feature flags are present #4733

Merged
merged 3 commits into from
Nov 9, 2020

Conversation

pavolum
Copy link
Contributor

@pavolum pavolum commented Nov 9, 2020

Description

If no preview features are in flight then this PR will add a message to the appsettings view.

Task Item

fixes #4731

Screenshots

image

@pavolum pavolum changed the title Fix: Adding text when no visible feature flags are present fix: Adding text when no visible feature flags are present Nov 9, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 56.289% when pulling 8177364 on removeFeatureFlagText into 8881e98 on main.

@cwhitten cwhitten merged commit 6079a15 into main Nov 9, 2020
@cwhitten cwhitten deleted the removeFeatureFlagText branch November 9, 2020 21:23
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Nov 11, 2020
* settingsPage: (53 commits)
  feat: Local Bots Start/Stop runtime (microsoft#4498)
  fix: Give a header to the enum fields (microsoft#4732)
  fix: Adding text when no visible feature flags are present (microsoft#4733)
  feat: Integrate OneAuth library (microsoft#4677)
  fix: update incompatible Trigger redirect url & icon size (microsoft#4719)
  fix: azure publish failed (microsoft#4725)
  fix onResize handler props (microsoft#4720)
  fix: add skillConfiguration settings for old bot (microsoft#4724)
  fix: undo/redo can't navigate to the correct position (microsoft#4722)
  Always enable allowClarmsValidator (microsoft#4717)
  fix: remodel ProjectTree for greater clarity (microsoft#4714)
  ci: Disable CI validation (microsoft#4646)
  make name text field disable in edit (microsoft#4699)
  add useMemo to improve performance (microsoft#4701)
  replace deprecated azure blob interface (microsoft#4702)
  move luBuildResolver to shared lib, apply in azurePublish (microsoft#4709)
  fix: the generated recognizer files is messy when the dialog name has the same prefix (microsoft#4708)
  fix: Update disabled property to booleanExpression across all the kinds + two uischema update (microsoft#4682)
  redirect to dialog root (microsoft#4698)
  fix: Notification deep link (microsoft#4700)
  ...
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…#4733)

* Adding text when no visible feature flags are present

* adding build generated files with localized text

Co-authored-by: Patrick Volum <pavolum@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'no preview feature' text in app setting if no visible feature flags are available
4 participants