Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite DevSkim to use the Application Inspector Engine #390

Merged
merged 33 commits into from
Aug 12, 2022
Merged

Rewrite DevSkim to use the Application Inspector Engine #390

merged 33 commits into from
Aug 12, 2022

Commits on Jul 27, 2022

  1. WIP refactor 

    Refactor DevSkim to use AI engine. I'm refactoring it in a separate project, which will then be tested against the original devskim using the same rules to validate behavior, then the "DevSkim.AI" project will be renamed back to "Microsoft.DevSkim" and the old version removed.
    @gfs
    gfs committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    dece8b4 View commit details
    Browse the repository at this point in the history

  2. WIP Checkin

    @gfs
    gfs committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    69613c1 View commit details
    Browse the repository at this point in the history

  3. Bump version for refactor.

    @gfs
    gfs committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    865af67 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. Implement rewritten Analyze Command

    @gfs
    gfs committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    8fd43fc View commit details
    Browse the repository at this point in the history

  2. Update DevSkimRuleProcessor.cs

    @gfs
    gfs committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    e7c54a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Refactor/Recreation of CLI 

    Trimmed down to the Analyze and Verify commands by leveraging the refactored AI based engine.

Pack command is no longer needed. Multiple rules files are simply embedded.
Catalogue command not implemented for now. I'm not clear on how useful it is.
Test command not implemented for now. Also not clear how much use it sees.
    @gfs
    gfs committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    0e0a3ff View commit details
    Browse the repository at this point in the history

  2. Update pipelines to use net6

    @gfs
    gfs committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    3010306 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Adds a new test project for the AI refactor 

    Adds initial test to validate the default rules.
Cleans up the gitignore in the dotnet dir.
    @gfs
    gfs committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    53a2983 View commit details
    Browse the repository at this point in the history

  2. More refactoring 

    CLI Analyze Now Runs and appears to be working.
Remainder of Enums which used dashes have been renamed.
Now load DevSkim's languages and comments rather than using App inspectors.
    @gfs
    gfs committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    fe56f9b View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Refactor old code a bit to remove rule pack dependency 

    Confirmed via some manual testing that new implementation does not miss any matches the old one found. And in fact it finds some matches that were not appearing with old engine.
    @gfs
    gfs committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    36bb01b View commit details
    Browse the repository at this point in the history

  2. Don't embed the "test" case files into the binary

    @gfs
    gfs committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    aace5fd View commit details
    Browse the repository at this point in the history

  3. Stop HTTP pattern from matching localhost 

    Fix #389
    @gfs
    gfs committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    9425311 View commit details
    Browse the repository at this point in the history

  4. Add option to CLI to skip git ignored files 

    Requires the git command to be present on the path.

Fix #148
    @gfs
    gfs committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    7b285c7 View commit details
    Browse the repository at this point in the history

  5. Add option to skip gathering excerpts

    @gfs
    gfs committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    7d6256f View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Fix http rule 

    Update nbgv
    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    60b065c View commit details
    Browse the repository at this point in the history

  2. Delete old implementation

    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c7dcfee View commit details
    Browse the repository at this point in the history

  3. Improve capture for http rule to include domain name.

    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    7748887 View commit details
    Browse the repository at this point in the history

  4. Rename .AI project to primary project's name

    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    bab6dd5 View commit details
    Browse the repository at this point in the history

  5. Gitignore cleanup

    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e198b8d View commit details
    Browse the repository at this point in the history

  6. Update solution with renamed project names

    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    a2899be View commit details
    Browse the repository at this point in the history

  7. Comment out Extension pipeline build 

    To allow refactored CLI build to work properly. Will be restored when rewritten extension is added back.
    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    820d76e View commit details
    Browse the repository at this point in the history

  8. More VS Pipeline

    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    0b6cf96 View commit details
    Browse the repository at this point in the history

  9. Remove call to removed rulepacker from github workflow

    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e09215e View commit details
    Browse the repository at this point in the history

  10. Update VS-codeql-analysis.yml

    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    5c44125 View commit details
    Browse the repository at this point in the history

  11. Fix github workflows

    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    6a7fa9d View commit details
    Browse the repository at this point in the history

  12. Update README.md

    @gfs
    gfs authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    294b205 View commit details
    Browse the repository at this point in the history

  13. Add test execution to the core pipeline

    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3a452ef View commit details
    Browse the repository at this point in the history

  14. Merge branch 'gfs/AiRewrite' of https://github.com/microsoft/DevSkim … 

    …into gfs/AiRewrite
    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b241ec7 View commit details
    Browse the repository at this point in the history

  15. Fix disabling VS Extension pipeline

    @gfs
    gfs committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    11d4572 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Update AI dependency for off by one fix

    @gfs
    gfs committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    adf4331 View commit details
    Browse the repository at this point in the history

  2. Try fix test on linux

    @gfs
    gfs committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    05f78f7 View commit details
    Browse the repository at this point in the history

  3. Fix CSProj properties.

    @gfs
    gfs committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    f8e5ea6 View commit details
    Browse the repository at this point in the history

  4. Restore readme reference

    @gfs
    gfs committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    563544c View commit details
    Browse the repository at this point in the history