Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite DevSkim to use the Application Inspector Engine #390

Merged
merged 33 commits into from
Aug 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
dece8b4
WIP refactor
gfs Jul 27, 2022
69613c1
WIP Checkin
gfs Jul 27, 2022
865af67
Bump version for refactor.
gfs Jul 27, 2022
8fd43fc
Implement rewritten Analyze Command
gfs Jul 29, 2022
e7c54a7
Update DevSkimRuleProcessor.cs
gfs Jul 29, 2022
0e0a3ff
Refactor/Recreation of CLI
gfs Aug 1, 2022
3010306
Update pipelines to use net6
gfs Aug 1, 2022
53a2983
Adds a new test project for the AI refactor
gfs Aug 2, 2022
fe56f9b
More refactoring
gfs Aug 2, 2022
36bb01b
Refactor old code a bit to remove rule pack dependency
gfs Aug 3, 2022
aace5fd
Don't embed the "test" case files into the binary
gfs Aug 3, 2022
9425311
Stop HTTP pattern from matching localhost
gfs Aug 3, 2022
7b285c7
Add option to CLI to skip git ignored files
gfs Aug 3, 2022
7d6256f
Add option to skip gathering excerpts
gfs Aug 3, 2022
60b065c
Fix http rule
gfs Aug 11, 2022
c7dcfee
Delete old implementation
gfs Aug 11, 2022
7748887
Improve capture for http rule to include domain name.
gfs Aug 11, 2022
bab6dd5
Rename .AI project to primary project's name
gfs Aug 11, 2022
e198b8d
Gitignore cleanup
gfs Aug 11, 2022
a2899be
Update solution with renamed project names
gfs Aug 11, 2022
820d76e
Comment out Extension pipeline build
gfs Aug 11, 2022
0b6cf96
More VS Pipeline
gfs Aug 11, 2022
e09215e
Remove call to removed rulepacker from github workflow
gfs Aug 11, 2022
5c44125
Update VS-codeql-analysis.yml
gfs Aug 11, 2022
6a7fa9d
Fix github workflows
gfs Aug 11, 2022
294b205
Update README.md
gfs Aug 11, 2022
3a452ef
Add test execution to the core pipeline
gfs Aug 11, 2022
b241ec7
Merge branch 'gfs/AiRewrite' of https://github.com/microsoft/DevSkim …
gfs Aug 11, 2022
11d4572
Fix disabling VS Extension pipeline
gfs Aug 11, 2022
adf4331
Update AI dependency for off by one fix
gfs Aug 12, 2022
05f78f7
Try fix test on linux
gfs Aug 12, 2022
f8e5ea6
Fix CSProj properties.
gfs Aug 12, 2022
563544c
Restore readme reference
gfs Aug 12, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 1 addition & 2 deletions .github/workflows/CLI-codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Setup .NET Core SDK
uses: actions/setup-dotnet@v1.7.2
with:
dotnet-version: 5.0.x
dotnet-version: 6.0.x

- name: Initialize CodeQL
uses: github/codeql-action/init@v1
Expand All @@ -39,7 +39,6 @@ jobs:

- name: Build DevSkim CLI
run: |
dotnet ../RulePacker/devskim.dll pack ../rules Microsoft.DevSkim/Resources/devskim-rules.json
dotnet restore Microsoft.DevSkim.CLI
dotnet build Microsoft.DevSkim.CLI -c Release
working-directory: ./DevSkim-DotNet
Expand Down
27 changes: 14 additions & 13 deletions .github/workflows/VS-codeql-analysis.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
name: "CodeQL (VS)"

on:
push:
branches:
- main
paths:
- DevSkim-DotNet/Microsoft.DevSkim/*
- DevSkim-DotNet/Microsoft.DevSkim.VSExtension/*
pull_request:
branches:
- main
schedule:
- cron: '0 3 * * 3'
# Temporarily disabled until VS extension rewrite
on: workflow_dispatch
# on:
# push:
# branches:
# - main
# paths:
# - DevSkim-DotNet/Microsoft.DevSkim/*
# - DevSkim-DotNet/Microsoft.DevSkim.VSExtension/*
# pull_request:
# branches:
# - main
# schedule:
# - cron: '0 3 * * 3'

jobs:
CodeQL-Build:
Expand All @@ -37,7 +39,6 @@ jobs:

- name: Build DevSkim VS Extension
run: |
dotnet ../RulePacker/devskim.dll pack ../rules Microsoft.DevSkim/Resources/devskim-rules.json
dotnet restore Microsoft.DevSkim.VSExtension
msbuild Microsoft.DevSkim.VSExtension /p:Configuration=Release /p:Platform=AnyCPU
working-directory: ./DevSkim-DotNet
Expand Down
13 changes: 6 additions & 7 deletions .github/workflows/publish-wasm-to-gh-pages.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: Publish Blazor

on:
push:
branches: [ main ]
# Temporarily disabled until Blazor rewrite
on: workflow_dispatch
# on:
# push:
# branches: [ main ]
jobs:
build:

Expand All @@ -16,10 +18,7 @@ jobs:
- name: Setup .NET Core
uses: actions/setup-dotnet@v1
with:
dotnet-version: 5.0.x

- name: Pack Rules
run: dotnet RulePacker/devskim.dll pack rules DevSkim-DotNet/Microsoft.DevSkim/Resources/devskim-rules.json
dotnet-version: 6.0.x

- name: Build
run: dotnet publish DevSkim-DotNet/Microsoft.DevSkim.Blazor --configuration Release --self-contained -r browser-wasm
Expand Down
5 changes: 2 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
*.vsix
DevSkim-DotNet/Microsoft.DevSkim/Resources/devskim-rules.json
DevSkim-DotNet/Microsoft.DevSkim.Blazor/bin/
DevSkim-DotNet/Microsoft.DevSkim.Blazor/obj/
DevSkim-DotNet/Microsoft.DevSkim.sln.DotSettings.user
DevSkim-DotNet/Microsoft.DevSkim.CLI/output.json
24 changes: 9 additions & 15 deletions DevSkim-DotNet/.gitignore
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
Microsoft.DevSkim/bin
Microsoft.DevSkim/obj
Microsoft.DevSkim.Tests/bin
Microsoft.DevSkim.Tests/obj
Microsoft.DevSkim.CLI/bin
Microsoft.DevSkim.CLI/obj
Microsoft.DevSkim.CLI.Tests/bin
Microsoft.DevSkim.CLI.Tests/obj
Microsoft.DevSkim.VSExtension/bin
Microsoft.DevSkim.VSExtension/obj
Microsoft.DevSkim.VSExtension.Tests/bin
Microsoft.DevSkim.VSExtension.Tests/obj
TestResults
packages
# Editor Configs
.idea/
.vs/
.vscode/settings.json
*.log

# Build artifacts
**/obj/
**/bin/

# Test Artifacts
TestResults
10 changes: 0 additions & 10 deletions DevSkim-DotNet/Microsoft.DevSkim.Blazor/App.razor

This file was deleted.

24 changes: 0 additions & 24 deletions DevSkim-DotNet/Microsoft.DevSkim.Blazor/CodeFile.cs

This file was deleted.

This file was deleted.

This file was deleted.

184 changes: 0 additions & 184 deletions DevSkim-DotNet/Microsoft.DevSkim.Blazor/Pages/Index.razor

This file was deleted.

Loading