Merge pull request #104 from microsoft/chore/tasks-linting

chore: tasks linting
microsoft · Sep 4, 2024 · 7ad6b26 · 7ad6b26
2 parents bf60bd4 + 43f6a5e
commit 7ad6b26
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/lib/apimanifest.csproj b/src/lib/apimanifest.csproj
@@ -31,6 +31,10 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.OpenApi.Readers" Version="1.6.20" />
+    <PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.11.20">
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
     <PackageReference Include="System.Text.Json" Version="[6.0,9.0)" />
   </ItemGroup>
 

diff --git a/tests/ApiManifest.Tests/Helpers/ParsingHelpersTests.cs b/tests/ApiManifest.Tests/Helpers/ParsingHelpersTests.cs
@@ -124,14 +124,14 @@ public async Task ParseOpenApiAsync()
         }
 
         [Fact]
-        public async Task ParseOpenApiWithWrongOpenApiUrl()
+        public async Task ParseOpenApiWithWrongOpenApiUrlAsync()
         {
             var openApiUri = new Uri("https://1CED4309-EFBF-41A8-9E8F-8BBA0CB3EEE5.com/NotValid.yaml");
             await Assert.ThrowsAsync<InvalidOperationException>(async () => await ParsingHelpers.ParseOpenApiAsync(openApiUri, false, CancellationToken.None));
         }
 
         [Fact]
-        public async Task ParseOpenApiWithOpenApiUrlWithAnInvalidSchema()
+        public async Task ParseOpenApiWithOpenApiUrlWithAnInvalidSchemaAsync()
         {
             var openApiUri = new Uri("xyx://contoso.com/openapi.yaml");
             await Assert.ThrowsAsync<ArgumentException>(async () => await ParsingHelpers.ParseOpenApiAsync(openApiUri, false, CancellationToken.None));

diff --git a/tests/ApiManifest.Tests/OpenAIPluginManifestTests.cs b/tests/ApiManifest.Tests/OpenAIPluginManifestTests.cs
@@ -531,14 +531,14 @@ public async Task GenerateOpenAIPluginManifestFromApiManifestOfAnApiDependencyAs
     }
 
     [Fact]
-    public async Task GenerateOpenAIPluginManifestFromApiManifestWithWrongApiDependency()
+    public async Task GenerateOpenAIPluginManifestFromApiManifestWithWrongApiDependencyAsync()
     {
         await Assert.ThrowsAsync<ApiManifestException>(
             async () => await exampleApiManifest.ToOpenAIPluginManifestAsync("https://avatars.githubusercontent.com/bar", "https://legalinfo.foobar.com", "ContosoApi", "./openapi.yml"));
     }
 
     [Fact]
-    public async Task GenerateOpenAIPluginManifestFromApiManifestWithEmptyApiDependencies()
+    public async Task GenerateOpenAIPluginManifestFromApiManifestWithEmptyApiDependenciesAsync()
     {
         var apiManifest = LoadTestApiManifestDocument();
         apiManifest.ApiDependencies.Clear();