chore: tasks linting #104
Merged
chore: tasks linting #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrelmiller
previously approved these changes
Aug 30, 2024
@darrelmiller this dependency brings the analyzers as well as a bunch of helpful Task management feature. Especially JoinedTaskFactory.Run which is much better than GetAwaiter().GetResult(). Once we fix the Task mess we'll be able to add just the analyzer |
baywet
force-pushed
the
chore/tasks-linting
branch
from
0294000
to
43f6a5e
Compare
|
disregard my last comment, I had added a dependency on the wrong package. The new dependency is private and does not impact downstream packages. |
darrelmiller
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.