feat(rush-lib): setup Rush Custom Tips #4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theJiawen
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
|
dmichon-msft
requested changes
Jun 15, 2023
refactor the Rush Custom Tips
theJiawen
force-pushed
the
feat/rush-custom-tips
branch
from
80f3eef
to
4c9c39b
Compare
Consider the case when the config file not exist.
1. Add json schema for the config and using it to do validation. 2. Renaming some types 3. Add some `@beta` tag.
theJiawen
force-pushed
the
feat/rush-custom-tips
branch
from
46a5953
to
dedd332
Compare
|
oops, I did a rebase, and it seems messed up the commit history. Should I do merging instead of rebasing? @dmichon-msft Update: reverted the changes |
theJiawen
force-pushed
the
feat/rush-custom-tips
branch
from
ed528bb
to
1d44256
Compare
dmichon-msft
reviewed
Aug 9, 2023
…tom-tips # Conflicts: # build-tests/install-test-workspace/workspace/common/pnpm-lock.yaml
…ough already that there won't be any confusion about whether it applies to Rush
…ough already that there won't be any confusion about whether it applies to Rush
…knownRushConfigFilenames inventory
dmichon-msft
approved these changes
Aug 11, 2023
…Jiawen; Removed CustomTipSeverity since we plan to replace this with a "tip visibility" setting instead
…d standardize that tip IDs must start with a "TIP_" prefix
octogonz
approved these changes
Aug 12, 2023
|
Tested using the https://github.com/microsoft/rush-example repo:
👍 |
|
Documentation for this feature is here: https://rushjs.io/pages/maintainer/custom_tips/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype PR for the design proposal #4207 . Any comments are welcomed.