Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rush-lib): setup Rush Custom Tips #4208

Merged
merged 38 commits into from
Aug 12, 2023
Merged

feat(rush-lib): setup Rush Custom Tips #4208

merged 38 commits into from
Aug 12, 2023

Commits on Jun 15, 2023

  1. feat(rush-lib): setup Rush Custom Tips

    @theJiawen
    theJiawen committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    1b488b9 View commit details
    Browse the repository at this point in the history

  2. chore: remove a useless file

    @theJiawen
    theJiawen committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    534365b View commit details
    Browse the repository at this point in the history

  3. chore: add the change log file

    @theJiawen
    theJiawen committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a14ad42 View commit details
    Browse the repository at this point in the history

  4. fix: lint

    @theJiawen
    theJiawen committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    dd42c72 View commit details
    Browse the repository at this point in the history

  5. Refactor Rush Custom Tips based on the comments

    @theJiawen
    theJiawen committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    cb12138 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. wip: refactoring 

    refactor the Rush Custom Tips
    @theJiawen
    theJiawen committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    4c9c39b View commit details
    Browse the repository at this point in the history

  2. Fix some tests 

    Consider the case when the config file not exist.
    @theJiawen
    theJiawen committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    b091151 View commit details
    Browse the repository at this point in the history

  3. fix an error

    @theJiawen
    theJiawen committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    84a3b7c View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Refactor the code based on comments 

    1. Add json schema for the config and using it to do validation.
2. Renaming some types
3. Add some `@beta` tag.
    @theJiawen
    theJiawen committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c497c64 View commit details
    Browse the repository at this point in the history

  2. Remove terminal from the CustomTipsConfiguration

    @theJiawen
    theJiawen committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ca9a428 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Move "rush-custom-tips.json" to the test repo

    @theJiawen
    theJiawen committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    ac0590e View commit details
    Browse the repository at this point in the history

  2. Update rush-sdk test snapshot

    @theJiawen
    theJiawen committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    dedd332 View commit details
    Browse the repository at this point in the history

  3. chore: update lockfile

    @theJiawen
    theJiawen committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    d32abf7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feat/rush-custom-tips

    @theJiawen
    theJiawen committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    0b8ddc8 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Fix a test due to interface change

    @theJiawen
    theJiawen committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    c897538 View commit details
    Browse the repository at this point in the history

  2. Refactor: renaming, adding test

    @theJiawen
    theJiawen committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    feb4d19 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Change a variable name to make it consistent

    @theJiawen
    theJiawen committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    881808d View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. chore: renaming to make the github check happy.

    @theJiawen
    theJiawen committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    61d492f View commit details
    Browse the repository at this point in the history

  2. chore: update rush-lib.api.md

    @theJiawen
    theJiawen committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    888e2d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Apply suggestions from code review 

    Co-authored-by: David Michon <dmichon@microsoft.com>
    @theJiawen @dmichon-msft
    theJiawen and dmichon-msft committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    1d44256 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Merge remote-tracking branch 'remotes/origin/main' into feat/rush-cus… 

    …tom-tips

# Conflicts:
#	build-tests/install-test-workspace/workspace/common/pnpm-lock.yaml
    @octogonz
    octogonz committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    fba6a8e View commit details
    Browse the repository at this point in the history

  2. Revise change file

    @octogonz
    octogonz committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4796d09 View commit details
    Browse the repository at this point in the history

  3. Rename "RushCustomTips" -> "CustomTips" because the name is unique en… 

    …ough already that there won't be any confusion about whether it applies to Rush
    @octogonz
    octogonz committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3dcf246 View commit details
    Browse the repository at this point in the history

  4. Rename "RushCustomTips" -> "CustomTips" because the name is unique en… 

    …ough already that there won't be any confusion about whether it applies to Rush
    @octogonz
    octogonz committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    083bbf1 View commit details
    Browse the repository at this point in the history

  5. Rename rush-custom-tips.json to custom-tips.json

    @octogonz
    octogonz committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2f187d2 View commit details
    Browse the repository at this point in the history

  6. Rename rush-custom-tips.json to custom-tips.json

    @octogonz
    octogonz committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    552b0bd View commit details
    Browse the repository at this point in the history

  7. Move custom-tips.json to common/config/rush folder and add it to the … 

    …knownRushConfigFilenames inventory
    @octogonz
    octogonz committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    7694f97 View commit details
    Browse the repository at this point in the history

  8. Remove unused "ANOTHER_ID_THAT_IS_EXPOSED_TO_CUSTOM" identifier

    @octogonz
    octogonz committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1e6429e View commit details
    Browse the repository at this point in the history

  9. rush rebuild

    @octogonz
    octogonz committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9c4e16c View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'remotes/origin/main' into feat/rush-cus… 

    …tom-tips
    @octogonz
    octogonz committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c9ef086 View commit details
    Browse the repository at this point in the history

  11. heft test -u

    @octogonz
    octogonz committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9385b42 View commit details
    Browse the repository at this point in the history

  12. Report an error for duplicate ids

    @octogonz
    octogonz committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c01a191 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Improved some config file field names based on a discussion with @the… 

    …Jiawen;

Removed CustomTipSeverity since we plan to replace this with a "tip visibility" setting instead
    @octogonz
    octogonz committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    191eeba View commit details
    Browse the repository at this point in the history

  2. Add a "rush init" template

    @octogonz
    octogonz committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    d81844c View commit details
    Browse the repository at this point in the history

  3. Rename PNPM_MISMATCH_DEPENDENCY to TIP_RUSH_INCONSISTENT_VERSIONS, an… 

    …d standardize that tip IDs must start with a "TIP_" prefix
    @octogonz
    octogonz committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    90b53f5 View commit details
    Browse the repository at this point in the history

  4. Add docs for "// (undocumented)" items in API report

    @octogonz
    octogonz committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    c0a86f4 View commit details
    Browse the repository at this point in the history

  5. Fix comparison logic

    @octogonz
    octogonz committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    1e365f4 View commit details
    Browse the repository at this point in the history

  6. Fix spacing

    @octogonz
    octogonz committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    06fb2ba View commit details
    Browse the repository at this point in the history