.Net: Add support for ImageContent to use data URIs in ChatPromptParser so templates can use base64 encoded images. #8401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat use base64 data encoding. This limitation arises from ChatPromptParser.cs only calling the ImageContent constructor requiring a Uri which results in an InvalidOperationException. The proposed fix involves a simple check to determine if the content starts with "data:", and if it does the ImageContent constructor that accepts a dataUri is utilized instead.
markwallace-microsoft
added
.NET
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@MarceloAGG Thanks for the contribution! I liked the approach, suggest adding also a |
…m/MarceloAGG/semantic-kernel-marcgarc into marcgarc-data-image-from-template
|
Good suggestion @RogerBarreto, |
MarceloAGG
commented
Aug 29, 2024
RogerBarreto
approved these changes
Aug 29, 2024
dotnet/samples/Concepts/PromptTemplates/HandlebarsVisionPrompts.cs
Outdated
Show resolved
Hide resolved
SergeyMenshykh
approved these changes
Aug 30, 2024
markwallace-microsoft
approved these changes
Aug 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
At present, including images in prompt templates using base64 data encoding is not possible. This limitation is due to
ChatPromptParser.csexclusively calling theImageContentconstructor that requires a URI, which leads to anInvalidOperationException. The change required is straightforward and the limitation has been discussed before, for example here. Closes #7150.Description
The proposed trivial fix involves a simple check to determine if the content starts with
data:, and if it does theImageContentconstructor that accepts adataUriis utilized instead.Contribution Checklist