Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Add support for ImageContent to use data URIs in ChatPromptParser so templates can use base64 encoded images. #8401

Merged
merged 9 commits into from
Aug 30, 2024
Merged

.Net: Add support for ImageContent to use data URIs in ChatPromptParser so templates can use base64 encoded images. #8401

merged 9 commits into from
Aug 30, 2024

Commits on Aug 27, 2024

  1. Currently, it is not possible to include images in prompt templates t… 

    …hat use base64 data encoding. This limitation arises from ChatPromptParser.cs only calling the ImageContent constructor requiring a Uri which results in an InvalidOperationException. The proposed fix involves a simple check to determine if the content starts with "data:", and if it does the ImageContent constructor that accepts a dataUri is utilized instead.
    @marcgarcms
    marcgarcms committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6442aa2 View commit details
    Browse the repository at this point in the history

  2. Small change to test method name

    @marcgarcms
    marcgarcms committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8bb0878 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into marcgarc-data-image-from-template

    @MarceloAGG
    MarceloAGG authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b1ce180 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Adding concept example

    @marcgarcms
    marcgarcms committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    a1c05f5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'marcgarc-data-image-from-template' of https://github.co… 

    …m/MarceloAGG/semantic-kernel-marcgarc into marcgarc-data-image-from-template
    @marcgarcms
    marcgarcms committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    1e57346 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into marcgarc-data-image-from-template

    @MarceloAGG
    MarceloAGG authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7e205c2 View commit details
    Browse the repository at this point in the history

  4. Small change

    @marcgarcms
    marcgarcms committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9415b81 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'marcgarc-data-image-from-template' of https://github.co… 

    …m/MarceloAGG/semantic-kernel-marcgarc into marcgarc-data-image-from-template
    @marcgarcms
    marcgarcms committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    27b4654 View commit details
    Browse the repository at this point in the history

  6. Small fix

    @marcgarcms
    marcgarcms committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0daf6ad View commit details
    Browse the repository at this point in the history