Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[settings] Acrylic opacity option could/should include percent sign. #10289

Closed
marcelwgn opened this issue May 30, 2021 · 3 comments · Fixed by #10369
Closed

[settings] Acrylic opacity option could/should include percent sign. #10289

marcelwgn opened this issue May 30, 2021 · 3 comments · Fixed by #10369
Labels
Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@marcelwgn
Copy link
Contributor

Description of the new feature/enhancement

Currently, when selecting the opacity of the acrylic option of a profile, the values range from 0 to 100. However in reality (and in the API of the AcrylicBrush) the values range from 0 to 1 (0 to 100%).

Proposed technical implementation details (optional)

I think we can just include a % sign at the end of the label.

Open questions

Does this need to be localized? Is a % sign optimal here or are there better alternatives?

If it's fine I would like to try work on this issue.
@marcelwgn marcelwgn added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 30, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 30, 2021
@zadjii-msft
Copy link
Member

That seems fine to me, good idea!

@zadjii-msft zadjii-msft added Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels May 31, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 31, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone May 31, 2021
@marcelwgn marcelwgn mentioned this issue Jun 8, 2021
Merged
1 task
@ghost ghost added the In-PR This issue has a related PR label Jun 8, 2021
@ghost ghost closed this as completed in #10369 Jun 9, 2021
@ghost ghost removed the In-PR This issue has a related PR label Jun 9, 2021
ghost pushed a commit that referenced this issue Jun 9, 2021
@marcelwgn
Add percentage sign to opacity slider values (#10369)
becc254 
This PR adds a new PercentageSignConverter that appends the percentage sign to a number. The new converter is being used by the Acrylic opacity slider label and the Background image opacity slider label.

* [x] Closes #10289
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jun 9, 2021
DHowett pushed a commit that referenced this issue Jul 7, 2021
@marcelwgn @DHowett
Add percentage sign to opacity slider values (#10369)
33774d2 
This PR adds a new PercentageSignConverter that appends the percentage sign to a number. The new converter is being used by the Acrylic opacity slider label and the Background image opacity slider label.

* [x] Closes #10289

(cherry picked from commit becc254)
@ghost
Copy link

ghost commented Jul 14, 2021

🎉This issue was addressed in #10369, which has now been successfully released as Windows Terminal v1.9.1942.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 14, 2021

🎉This issue was addressed in #10369, which has now been successfully released as Windows Terminal Preview v1.10.1933.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Add percentage sign to opacity slider values marcelwgn/terminal
2 participants
@marcelwgn @zadjii-msft