Add percentage sign to opacity slider values

[marcelwgn]

This PR adds a new PercentageSignConverter that appends the percentage sign to a number. The new converter is being used by the Acrylic opacity slider label and the Background image opacity slider label.

• Closes [settings] Acrylic opacity option could/should include percent sign. #10289

[carlos-zamora]

Really just blocking over the PercentageSignConverter::ConvertBack. The rest are just nits.

[carlos-zamora]

Suggested change

	namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
	{
	struct PercentageSignConverter : PercentageSignConverterT<PercentageSignConverter>
	{
	PercentageSignConverter() = default;
	Windows::Foundation::IInspectable Convert(Windows::Foundation::IInspectable const& value,
	Windows::UI::Xaml::Interop::TypeName const& targetType,
	Windows::Foundation::IInspectable const& parameter,
	hstring const& language);
	Windows::Foundation::IInspectable ConvertBack(Windows::Foundation::IInspectable const& value,
	Windows::UI::Xaml::Interop::TypeName const& targetType,
	Windows::Foundation::IInspectable const& parameter,
	hstring const& language);
	};
	}
	namespace winrt::Microsoft::Terminal::Settings::Editor::factory_implementation
	{
	BASIC_FACTORY(PercentageSignConverter);
	}
	DECLARE_CONVERTER(winrt::Microsoft::Terminal::Settings::Editor, PercentageSignConverter);

nit: here's a nice macro we have to make this easier :)

[carlos-zamora]

nit: you could also throw this declaration into PercentageConverter.h (and the implementation into the corresponding cpp file). That way we have less files going around.

See https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsEditor/StringIsNotDesktopConverter.h, if interested. We did the same thing there.

[marcelwgn]

I'm not too much of a fan of putting that in the PercentageConverter.h file since it's not really related to this. How about (a future) refactor, we have a DeclareConverter.h where we can put those statements? That way, we probably could get rid of a few headers files more easily.

[DHowett]

My intent is to move us all away from object-based converters in the future, so we can put a pin in this.

[DHowett]

Thanks for this! It's excellent.

I wanted to make a comment about using bound function converters instead of class-based converters, but I'll hold off for now. I don't know if functions work with Binding, and I do not understand WHY we are using Binding instead of x:Bind here, so I am not going to force you to rearchitect our code.

Thanks so much. 😄

[ghost]

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[carlos-zamora]

Thanks!

@DHowett FYI you could also throw this in Stable if you wanted to.

[marcelwgn]

You are too kind @DHowett and @carlos-zamora !

Regarding the bound functional converters, if there are plans for this, I can definitely try and help with refactoring this! Is there already some kind of tracking for this (e.g. an issue)?

[ghost]

🎉Windows Terminal v1.9.1942.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download

[ghost]

🎉Windows Terminal Preview v1.10.1933.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download