Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal 1.13+ requires Windows 20H1 or greater #11371

Closed
zadjii-msft opened this issue Sep 29, 2021 · 2 comments · Fixed by #12129
Closed

Terminal 1.13+ requires Windows 20H1 or greater #11371

zadjii-msft opened this issue Sep 29, 2021 · 2 comments · Fixed by #12129
Assignees
@zadjii-msft
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products. Resolution-Answered Related to questions that have been answered Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.13

Comments

@zadjii-msft
Copy link
Member

(for MSFT folks, this is bumping the min version from 19H1 to Vb)

There's a couple big reasons why:

When we do this, we should make sure to revert the changes that fixed #11285
@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered Product-Meta The product is the management of the products. labels Sep 29, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Sep 29, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 29, 2021
@zadjii-msft zadjii-msft pinned this issue Sep 29, 2021
@zadjii-msft zadjii-msft changed the title [Announcement] In a coming Terminal version, we'll be bumping the MinVersion to 10.0.19041.0 / 2004 / Vb In a coming Terminal version, we'll be bumping the MinVersion to 10.0.19041.0 / 2004 / Vb Sep 29, 2021
This was referenced Sep 29, 2021
Merged
Merged
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 15, 2021
@zadjii-msft zadjii-msft self-assigned this Jan 6, 2022
@zadjii-msft zadjii-msft mentioned this issue Jan 10, 2022
Merged
1 task
@ghost ghost added the In-PR This issue has a related PR label Jan 10, 2022
@ghost ghost closed this as completed in #12129 Jan 11, 2022
ghost pushed a commit that referenced this issue Jan 11, 2022
@zadjii-msft
Bump the minversion of the Terminal (#12129)
6b65713 
As discussed. We're not going to be able to consistently get bugfixes below Vb anymore, so let's leave that as the MinVersion, so we can start adding features that depend on those bugfixes.

* [x] Closes #11371
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 11, 2022
@DHowett DHowett changed the title In a coming Terminal version, we'll be bumping the MinVersion to 10.0.19041.0 / 2004 / Vb Terminal 1.13+ Requires Windows 20H1 or greater Feb 3, 2022
@DHowett DHowett changed the title Terminal 1.13+ Requires Windows 20H1 or greater Terminal 1.13+ requires Windows 20H1 or greater Feb 3, 2022
@LoganDark
Copy link

I have 19041.928, is that covered or do you really only support 20H1 now?

@zadjii-msft
Copy link
Member Author

@LoganDark I'm under the impression that 20H1 is build number 19041, so that should work.

@LoganDark LoganDark mentioned this issue May 10, 2022
Closed
@DHowett DHowett unpinned this issue May 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products. Resolution-Answered Related to questions that have been answered Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.13
Development

Successfully merging a pull request may close this issue.

Bump the minversion of the Terminal microsoft/terminal
3 participants
@DHowett @LoganDark @zadjii-msft