Crash opening/closing close... submenu multiple times #8238
Comments
ghost
added
Needs-Triage
|
Oh hey, I'm glad there's an actual issue for this now. We've known about this for some time, just never filed an issue for it. We're pretty confident that this is a XAML Islands bug, but it'll be good to have a thread tracking it on our side. |
zadjii-msft
added
Area-User Interface
zadjii-msft
removed
the
Needs-Triage
|
I'm punting this to 2.0, because we don't have LoS on a fix from the Terminal side. It might need a system XAML fix, which would be especially annoying. |
|
Oh NO. This is also gonna have to block #1571. People really want to stick their profile in nested menus. As soon as this is available, people are going to use it, and inevitably hit this. Yikes. |
|
It would be awesome if you could push internally for a fix because this is blocking on my app too. |
|
FWIW I think there is an easier repro case if you need one. Just open the context menu and move the mouse up and down... This is on 1.6.10272.0 |
|
I suppose this is going to take some time to be fixed at the system XAML level. Considering the context menu is not so crowded at the moment, would it be bad placing the items right above the Close one, for the time being? At least people could use the feature. |
|
Seeing as the upstream issue is flagged needs-winui-3, I don't even expect it to get ever fixed in system Xaml islands (which is annoying me because I can't migrate to WinUI 3 right away it's missing features from system Xaml I rely on) |
Do not add a submenu until microsoft#8238 crash is fixed.
I'm sending a PR for this, feel free to throw it away if you don't like it 😄 |
ghost
added
Resolution-Fix-Committed
## Summary of the Pull Request Add the "Close other tabs"/"Close tabs to the right" menu items straight to the tab context menu to work around #8238. We can't add them into a dedicated sub-menu until the upstream crash is fixed. ## References #8238 ## PR Checklist * [X] Closes #8238 * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. ## Detailed Description of the Pull Request / Additional comments Moved the creation of the close menu items to a single function. Once the originating crash is fixed, the sub-menu can be restored by just replacing a few lines of code. ## Validation Steps Performed 
## Summary of the Pull Request Add the "Close other tabs"/"Close tabs to the right" menu items straight to the tab context menu to work around #8238. We can't add them into a dedicated sub-menu until the upstream crash is fixed. ## References #8238 ## PR Checklist * [X] Closes #8238 * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. ## Detailed Description of the Pull Request / Additional comments Moved the creation of the close menu items to a single function. Once the originating crash is fixed, the sub-menu can be restored by just replacing a few lines of code. ## Validation Steps Performed  (cherry picked from commit 2065fa7)
Add the "Close other tabs"/"Close tabs to the right" menu items straight to the tab context menu to work around #8238. We can't add them into a dedicated sub-menu until the upstream crash is fixed. * [X] Closes #8238 * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Moved the creation of the close menu items to a single function. Once the originating crash is fixed, the sub-menu can be restored by just replacing a few lines of code.  (cherry picked from commit 2065fa7) (cherry picked from commit c4e02e7)
Add the "Close other tabs"/"Close tabs to the right" menu items straight to the tab context menu to work around #8238. We can't add them into a dedicated sub-menu until the upstream crash is fixed. * [X] Closes #8238 * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Moved the creation of the close menu items to a single function. Once the originating crash is fixed, the sub-menu can be restored by just replacing a few lines of code.  (cherry picked from commit 2065fa7) (cherry picked from commit c4e02e7)
|
🎉This issue was addressed in #9859, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #9859, which has now been successfully released as Handy links: |
Environment
Steps to reproduce
The application exits when you:
Expected behavior
It does not crash
Actual behavior
It crashes
Other info
Feedback hub link: https://aka.ms/AAabnvq
See also #7728 (comment) and #7728 (comment). Unfortunately I don't know how to debug it myself...
The text was updated successfully, but these errors were encountered: