Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation error: 'Shell' translated as '外壳' in Chinese localization #17764

Closed
nguyen-dows opened this issue Aug 21, 2024 · 3 comments · Fixed by #17958
Closed

Translation error: 'Shell' translated as '外壳' in Chinese localization #17764

nguyen-dows opened this issue Aug 21, 2024 · 3 comments · Fixed by #17958
Labels
Area-Localization In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@nguyen-dows
Copy link
Contributor

nguyen-dows commented Aug 21, 2024 •
edited
Loading

Windows Terminal version

1.19.10821.0

Windows build number

No response

Other Software

No response

Steps to reproduce

(Copied from docs issue #793

Describe the bug
terminal/src/cascadia/TerminalSettingsEditor/Resources/zh-CN/Resources.resw
image
In the Windows Terminal, the word 'Shell' is incorrectly translated as '外壳' in the Chinese (Simplified) localization. This translation may lead to confusion, as 'Shell' in technical terms usually remains untranslated.

Expected Behavior

The word 'Shell' should not be translated in this context, to avoid misunderstanding among users.

Actual Behavior

Screenshots
image

Additional context
I recommend keeping 'Shell' untranslated in this and similar technical contexts.
@nguyen-dows nguyen-dows added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 21, 2024
@nguyen-dows nguyen-dows mentioned this issue Aug 21, 2024
Closed
@nguyen-dows nguyen-dows added Area-Localization Product-Terminal The new Windows Terminal. Area-Settings UI Anything specific to the SUI and removed Area-Settings UI Anything specific to the SUI labels Aug 21, 2024
@nguyen-dows
Copy link
Contributor Author

@NOname-awa could you provide me the Windows Terminal version and Windows build number for that localization issue?

@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 21, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Aug 21, 2024
@NOname-awa
Copy link

@NOname-awa could you provide me the Windows Terminal version and Windows build number for that localization issue?

8B}O)A~PURWQ%4 {G{$OK

This is my Terminal version (1.19.10821.0)

@lhecker lhecker self-assigned this Sep 9, 2024
@lhecker
Copy link
Member

lhecker commented Sep 11, 2024

Reported internally as GCS-716557.

@lhecker lhecker removed their assignment Sep 11, 2024
@DHowett DHowett mentioned this issue Sep 26, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added In-PR This issue has a related PR Needs-Tag-Fix Doesn't match tag requirements labels Sep 26, 2024
DHowett pushed a commit that referenced this issue Sep 26, 2024
@consvc @DHowett
Localization Updates - main - 09/26/2024 19:14:21 (#17958)
49e96f2 
Closes #17752
Closes #17764
Closes #17830

(cherry picked from commit 59dc5ef)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgTX8OQ
Service-Version: 1.21
DHowett pushed a commit that referenced this issue Sep 26, 2024
@consvc @DHowett
Localization Updates - main - 09/26/2024 19:14:21 (#17958)
1814489 
Closes #17752
Closes #17764
Closes #17830

(cherry picked from commit 59dc5ef)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgTX8OU
Service-Version: 1.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Localization In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Localization Updates - main - 09/26/2024 19:14:21 microsoft/terminal
4 participants
@lhecker @carlos-zamora @nguyen-dows @NOname-awa