Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagonal blanks when using vim #3277

Closed
lzybkr opened this issue Oct 21, 2019 · 13 comments · Fixed by #3292
Closed

Diagonal blanks when using vim #3277

lzybkr opened this issue Oct 21, 2019 · 13 comments · Fixed by #3292
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.0

Comments

@lzybkr
Copy link
Member

lzybkr commented Oct 21, 2019

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 0.6.2911.0

Any other software?
Windows vim 8.1.1006

Steps to reproduce

Open a file in vim and type Ctrl+b repeatedly. The 3 screenshots below are each after typing Ctrl+b once.

Expected behavior

No weird blank diagonals while using vim.

Actual behavior

image
image
image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 21, 2019
@DHowett-MSFT
Copy link
Contributor

Repro'd. Time to pop into the debugger and see what's coming out of conhost. 😄

@DHowett-MSFT DHowett-MSFT added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 22, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 22, 2019
@DHowett-MSFT
Copy link
Contributor

This regressed with #2965 due to the cursor positioning changes.

@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 22, 2019
Merged
5 tasks
@skyline75489
Copy link
Collaborator

This is really a "wow" bug, as in "wow how did this happen" and also "wow how did you notice this".

DHowett-MSFT pushed a commit that referenced this issue Oct 22, 2019
@DHowett
Don't reset the cursor X to 0 when we would otherwise wrap
59e1baf 
Fixes #3277.
Partially reverts #2965.
@skyline75489
Copy link
Collaborator

Yeah, I also think it may has something to do with #2965 . Should we just revert both #2965 and #2932 ?

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Oct 22, 2019 •
edited
Loading

There's two "real" solutions to the issue in #1360 -- one is to always do "deferred EOL" for terminal (if we go off the edge of the screen, only increment Y and reset X for the next character). This is partially supported by Cursor, which has deferred EOL options.

The other is to implement #780. 😄

@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 22, 2019
Closed
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 22, 2019
@DHowett-MSFT
Copy link
Contributor

@skyline75489 I wish we didn't have to, but I do feel safest about reverting both of them.

@skyline75489
Copy link
Collaborator

@DHowett-MSFT I'm OK with it. No hard feeling. The CJK support is, after all, right now far from ideal with #2213 still open. Reverting those commits doesn't really hurt anyone, at least not me.

But #1360 and the crash while resizing will still be in the dark. That's somewhat discomforting.

DHowett-MSFT pushed a commit that referenced this issue Oct 22, 2019
@DHowett
Revert two cursor changes that cause crashing and rendering artifacts
549369e 
Revert "Fix cursor redrawing crash (#2965)"
This reverts commit 926a2e3.

Revert "Fix double width cursor for CJK characters (#2932)"
This reverts commit eafa884.

Fixes #3277.
Fully reverts #2965, #2932.
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 22, 2019
Merged
5 tasks
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 22, 2019
miniksa pushed a commit that referenced this issue Oct 22, 2019
@DHowett @miniksa
Revert two cursor changes that cause crashing and rendering art… (#3292)
d6790c0 
Revert "Fix cursor redrawing crash (#2965)"
This reverts commit 926a2e3.

Revert "Fix double width cursor for CJK characters (#2932)"
This reverts commit eafa884.

Fixes #3277.
Fully reverts #2965, #2932.
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 23, 2019
Closed
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 30, 2019
@lzybkr
Copy link
Member Author

lzybkr commented Jan 29, 2020 •
edited
Loading

@DHowett-MSFT - I'm seeing this issue again in vim using Version: 0.9.271.0

image

I don't yet have a consistent repro though.

And note - the duplicate lines are expected in this screenshot, but the blanks on the duplicate lines are not.

@DHowett-MSFT
Copy link
Contributor

Ugh.

@DHowett-MSFT DHowett-MSFT reopened this Jan 29, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 29, 2020
@DHowett-MSFT DHowett-MSFT removed the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 29, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v0.9 milestone Jan 29, 2020
@DHowett-MSFT DHowett-MSFT added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 29, 2020
@DHowett-MSFT DHowett-MSFT mentioned this issue Jan 29, 2020
Merged
3 tasks
@DHowett-MSFT
Copy link
Contributor

This likely regressed with #4150 (@lhecker) -- this ares has traditionally been frustrating to work in because Terminal doesn't support Delayed EOL properly.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 31, 2020
@lhecker
Copy link
Member

lhecker commented Feb 1, 2020

I'm sorry. 😓 Normally I'd try and remedy the issue now, but I'm sadly unable to reproduce it.
I tried various files in vim and in none of them did CtrlB generate any blank spots for me. Do I have to modify vim in any fashion for this to happen?

@zadjii-msft
Copy link
Member

Hey @lzybkr are you still seeing this? If you can consistently repro this, @DHowett-MSFT's got an idea of how you might be able to get us some debug output to help us investigate ☺️

@lzybkr
Copy link
Member Author

lzybkr commented Apr 2, 2020

I haven't seen it for awhile, I'll close it and reopen if I see it again.

@lzybkr lzybkr closed this as completed Apr 2, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.0
6 participants
@lzybkr @lhecker @skyline75489 @DHowett-MSFT @zadjii-msft @cinnamon-msft