Revert two cursor changes that cause crashing and rendering artifacts #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-zamora
approved these changes
Oct 22, 2019
miniksa
approved these changes
Oct 22, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Fix cursor redrawing crash (#2965)"
This reverts commit 926a2e3.
Revert "Fix double width cursor for CJK characters (#2932)"
This reverts commit eafa884.
Fixes #3277.
Fully reverts #2965, #2932.
Summary of the Pull Request
Chatted with @skyline75489 about the appropriate fix for #3277, and we decided that it'd be best to revert these two PRs until we can get them in better shape.
PR Checklist
Validation
A whole bunch of bisecting.