Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: show an indicator if there's a bell in the tab #8106

Closed
skyline75489 opened this issue Oct 30, 2020 · 9 comments · Fixed by #8637
Closed

Feature Request: show an indicator if there's a bell in the tab #8106

skyline75489 opened this issue Oct 30, 2020 · 9 comments · Fixed by #8637
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.6

Comments

@skyline75489
Copy link
Collaborator

Description of the new feature/enhancement

This is a pretty straight-forward one. I know iTerm2 has this. As a ex-iOS developer I found it very useful to not only hear the bell but also know which tab is actually triggering the bell.

Proposed technical implementation details (optional)

I think we need a spec for this, to display some kind of accessories in the tab, besides icon and title.
@skyline75489 skyline75489 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 30, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 30, 2020
@skyline75489
Copy link
Collaborator Author

OK now that I think of it, the title is kinda bad. @zadjii-msft Please help me with my English and change the title to something more explanatory.

@zadjii-msft
Copy link
Member

OK now that I think of it, the title is kinda bad. @zadjii-msft Please help me with my English and change the title to something more explanatory.

Oh I knew exactly what you meant by this, don't sweat 😆

We've had mockups of this dating back to some of the earliest Terminal mockups actually. I'm surprised we didn't already have an issue for it, but that makes sense considering we only just landed the bell in #7679.

I'm mildly worried that we're going to be stuffing a lot of info into the tab pretty soon - the "zoom" indicator, the progress ring, the bell/mute indicator, but I'm not that worried. I think the number of people who are doing all simultaneously will be fairly low.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Oct 30, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 30, 2020
@mdtauk
Copy link

mdtauk commented Oct 30, 2020

OK now that I think of it, the title is kinda bad. @zadjii-msft Please help me with my English and change the title to something more explanatory.

Oh I knew exactly what you meant by this, don't sweat 😆

We've had mockups of this dating back to some of the earliest Terminal mockups actually. I'm surprised we didn't already have an issue for it, but that makes sense considering we only just landed the bell in #7679.

I'm mildly worried that we're going to be stuffing a lot of info into the tab pretty soon - the "zoom" indicator, the progress ring, the bell/mute indicator, but I'm not that worried. I think the number of people who are doing all simultaneously will be fairly low.

If you decide to implement the status bar, things like Zoom indication could go there. I see little reason you need to know a tab's console has been zoomed, unless it is the current active tab.

@j4james
Copy link
Collaborator

j4james commented Oct 31, 2020

This is closely related to #1608, if not a duplicate.

@zadjii-msft
Copy link
Member

I agree that this is closely related, but I'm gonna hold off calling this a dupe. I think I'd rather have this issue specifically track displaying the bell icon in the tab, and the other issue for displaying the alert in the taskbar. They're pretty similar, but I could see people wanting one or the other (or neither, or both), so we should probably have them all configurable independently.

I'll add both of them over to #6700, because they're sorta related. They're all about displaying some state to the user either with the tab or the taskbar.

@zadjii-msft zadjii-msft mentioned this issue Nov 2, 2020
Open
4 tasks
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 2, 2020
@skyline75489 skyline75489 mentioned this issue Nov 3, 2020
Merged
@mpela81
Copy link
Contributor

mpela81 commented Nov 16, 2020

How long should a bell indicator stay on the tab btw?

@zadjii-msft
Copy link
Member

Maybe like 1 second, then a 1 second fade? I suppose it should be just about the same as if a Edgium tab played a bell, for consistency.

@zadjii-msft
Copy link
Member

Also, @mpela81, if you're interested in working on this, you might want to hold off until #8227 is merged. That might make adding the XAML element to the header a bit easier 😉

@ghost ghost mentioned this issue Nov 23, 2020
Closed
6 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Nov 23, 2020
@PankajBhojwani PankajBhojwani mentioned this issue Dec 22, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Dec 22, 2020
@ghost ghost closed this as completed in #8637 Jan 22, 2021
ghost pushed a commit that referenced this issue Jan 22, 2021
@PankajBhojwani
Show indicator of bell in tab (#8637)
02fd7a0 
When we emit a BEL (visual or audible), show an indicator in the tab
header

If the tab the BEL is coming from is not focused when the BEL is raised,
the indicator in its header will be removed when the tab gains focus. If
the tab was already focused when the BEL was emitted, then the indicator
goes away after 2 seconds.

Closes #8106
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 22, 2021
mpela81 pushed a commit to mpela81/terminal that referenced this issue Jan 28, 2021
@PankajBhojwani @mpela81
Show indicator of bell in tab (microsoft#8637)
96daeb0 
When we emit a BEL (visual or audible), show an indicator in the tab
header

If the tab the BEL is coming from is not focused when the BEL is raised,
the indicator in its header will be removed when the tab gains focus. If
the tab was already focused when the BEL was emitted, then the indicator
goes away after 2 seconds.

Closes microsoft#8106
@sarim
Copy link
Contributor

sarim commented Feb 2, 2021

While the audible bell is very annoying, the visual bell is kinda hard to notice. Maybe instead of plan bell icon, 🔔 can be used? Also bell icon only prepends to tab title, maybe It can be appended to taskbar title too. Or superimpose a little bell icon to taskbar's terminal icon....

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.6
6 participants
@mpela81 @sarim @j4james @skyline75489 @mdtauk @zadjii-msft