Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make terminal beeps highlight Windows Terminal in the taskbar, to get user attention when backgrounded #1608

Closed
mikemaccana opened this issue Jun 25, 2019 · 5 comments · Fixed by #8215
Closed

Make terminal beeps highlight Windows Terminal in the taskbar, to get user attention when backgrounded #1608

mikemaccana opened this issue Jun 25, 2019 · 5 comments · Fixed by #8215
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Area-VT Virtual Terminal sequence support Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Conpty For console issues specifically related to conpty Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@mikemaccana
Copy link
Contributor

Scenario

A long running task is running in the Terminal. The user is using another app.

Something happens requiring attention from the user.

What happens now

The terminal beeps, but the user doesn't know about it, and doesn't see the issue.

What should happen

The taskbar item becomes highlighted, showing that the terminal needs attention (optionally this can be disabled).
@mikemaccana mikemaccana added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 25, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 25, 2019
@mikemaccana mikemaccana changed the title Make terminal beeps highlight the Taskbar, to get user attention when backgrounded Make terminal beeps highlight Windows Terminal in the taskbar, to get user attention when backgrounded Jun 25, 2019
@carlos-zamora carlos-zamora added the Product-Terminal The new Windows Terminal. label Jun 25, 2019
@DHowett-MSFT
Copy link
Contributor

Yep, we should have some bell support. This also requires us to push bells through the conpty layer. 😄

@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Jun 27, 2019
@DHowett-MSFT DHowett-MSFT added Product-Conpty For console issues specifically related to conpty Area-User Interface Issues pertaining to the user interface of the Console or Terminal Area-VT Virtual Terminal sequence support and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 27, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 27, 2019
@tstackhouse
Copy link

Yep, we should have some bell support. This also requires us to push bells through the conpty layer. 😄

Does this include audible bells? Because I can't for the life of me get audible bells to work.

@zadjii-msft
Copy link
Member

@tstackhouse yes it does.

@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 8, 2019
Closed
@j4james j4james mentioned this issue Sep 28, 2019
Closed
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this issue Aug 12, 2020
Closed
@j4james j4james mentioned this issue Sep 19, 2020
Merged
6 tasks
DHowett pushed a commit that referenced this issue Oct 1, 2020
@j4james
Add support for the BEL control in Windows Terminal (#7679)
09cc5f4 
This commit makes the Windows Terminal play an audible sound when the
`BEL` control character is output.

The `BEL` control was already being forwarded through conpty, so it was
just a matter of hooking up the `WarningBell` dispatch method to
actually play a sound. I've used the `PlaySound` API to output the sound
configured for the "Critical Stop" system event (aka _SystemHand_),
since that is the sound used in conhost.

## Validation

I've manually confirmed that the terminal produces the expected sound
when executing `echo ^G` in a cmd shell, or `printf "\a"` in a WSL bash
shell.

References:
* There is a separate issue (#1608) to deal with configuring the `BEL`
  to trigger visual forms of notification.
* There is also an issue (#2360) requesting an option to disable the
  `BEL`.

Closes #4046
@bobvandevijver
Copy link

Now that #7793 has been merged, I think this issue will be the main one for tracking the visual bell?
Anyways, I would love to see both: the audible and visible notification combined, probably with a setting as suggested here.

@j4james
Copy link
Collaborator

j4james commented Oct 16, 2020

FYI there is a system-wide option called Show audio alerts visually, which you can set to flash the window border (or even the whole screen), when the bell is triggered. It's probably not exactly what you want, but it may do as temporary solution.

@j4james j4james mentioned this issue Oct 31, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Nov 2, 2020
Open
4 tasks
@PankajBhojwani PankajBhojwani mentioned this issue Nov 10, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Nov 10, 2020
@ghost ghost closed this as completed in #8215 Nov 18, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Nov 18, 2020
ghost pushed a commit that referenced this issue Nov 18, 2020
@PankajBhojwani
Add a setting to flash the taskbar when the terminal emits BEL (#8215)
1fbcf34 
The terminal taskbar icon can now flash when the BEL sequence is
emitted, to let the user know something needs their attention. 

The `BellStyle` setting can now be set to `audible`, `visual` or both or
none. When the pane receives a BEL event and the `bellStyle` includes
`visual`, we bubble the event up all the way to `AppHost` to handle
flashing the taskbar. 

Closes #1608
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Area-VT Virtual Terminal sequence support Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Conpty For console issues specifically related to conpty Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Add a setting to flash the taskbar when the terminal emits BEL microsoft/terminal
7 participants
@tstackhouse @mikemaccana @bobvandevijver @j4james @carlos-zamora @DHowett-MSFT @zadjii-msft