Add a setting to configure the audible bell #7793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Settings
DHowett
reviewed
Oct 1, 2020
| @@ -76,6 +76,7 @@ namespace winrt::TerminalApp::implementation | |||
| GETSET_PROPERTY(bool, StartOnUserLogin, false); | |||
| GETSET_PROPERTY(bool, AlwaysOnTop, false); | |||
| GETSET_PROPERTY(bool, UseTabSwitcher, true); | |||
| GETSET_PROPERTY(winrt::TerminalApp::BellStyle, BellStyle, winrt::TerminalApp::BellStyle::Audible); | |||
There was a problem hiding this comment.
🚨 Carlos, this will be a conflict for you
DHowett
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Perfect. Do we want it to be per-profile?
This will have an interesting effect on some applications, and users may be confused by it. There's some applications that emit their own bells using the same API, and people may be upset that we can't suppress them.
Not a complaint, just something to be aware of!
|
This could eventually be a flag mapper ( |
PankajBhojwani
approved these changes
Oct 1, 2020
carlos-zamora
previously requested changes
Oct 2, 2020
There was a problem hiding this comment.
Update the docs and schema!
Also, please make my life easier and wait until after #7667 merges.
ghost
added
the
Needs-Author-Feedback
zadjii-msft
added a commit
to MicrosoftDocs/terminal
that referenced
this pull request
Oct 5, 2020
ghost
removed
the
Needs-Author-Feedback
…isable-bell # Conflicts: # src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl
miniksa
approved these changes
Oct 9, 2020
…isable-bell # Conflicts: # src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp # src/cascadia/TerminalSettingsModel/GlobalAppSettings.h # src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl # src/cascadia/TerminalSettingsModel/defaults.json
zadjii-msft
dismissed
carlos-zamora’s stale review
I updated the docs and schema
DHowett
reviewed
Oct 15, 2020
| "bellStyle": { | ||
| "default": "audible", | ||
| "description": "Controls what happens when the application emits a BEL character. When set to \"audible\", the Terminal will play a sound. When set to \"none\", nothing will happen.", | ||
| "$ref": "#/definitions/BellStyle" |
There was a problem hiding this comment.
i'm glad it caught this b/c it wouldn't have been a valid schema otherwise!@ 😉
DHowett
approved these changes
Oct 15, 2020
DHowett
changed the title
carlos-zamora
added a commit
that referenced
this pull request
Oct 30, 2020
## Summary of the Pull Request Since we've started working on the Settings UI, a few settings have been added on `main`. This adds those missing settings over. ## References Missing settings include... - #7364: `disableAnimations` - #7873: `launchMode` `focus` and `maximizedFocus` - #7793: `bellStyle` ## Validation Steps Performed Verified that those settings appear properly in the Settings UI.
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds a new setting,
bellStyle, to be able to disable the audible bell added in #7679. Currently, this setting accepts two values:audible: play a noise on a bellnone: Don't play a noise.In the future, we can add a
"bellStyle": "visible"for flashing the Terminal instead of making a noise on bell.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
FOR DISCUSSION: Should
bellStylejust bebell?Validation Steps Performed
Pressing Ctrl+G in cmd, and hitting enter is an easy way of triggering a bell. I set the setting to
none, and presto, the bell stopped.