Replace "acrylic" with "acrylic material" in i18n strings #12505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Acrylic material" is the official name as used on Microsoft Docs and should ensure it gets properly translated in all languages.
ghost
added
Area-Localization
Area-Settings UI
zadjii-msft
reviewed
Feb 17, 2022
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
|
carlos-zamora
approved these changes
Feb 17, 2022
| <value>Enable acrylic</value> | ||
| <comment>Header for a control to toggle the acrylic-like rendering of the background. The acrylic material creates a translucent texture.</comment> | ||
| <value>Enable acrylic material</value> | ||
| <comment>Header for a control to toggle the use of acrylic material for the background. "Acrylic material" is a Microsoft-specific term.</comment> |
There was a problem hiding this comment.
idk how localization works, exactly. But would it be helpful to link the doc you mentioned earlier? That way it's consistent?
There was a problem hiding this comment.
(same goes for the Globals_AcrylicTabRow entry above)
There was a problem hiding this comment.
I've added links to the en-us docs.
DHowett
approved these changes
Feb 17, 2022
|
Everyone alright with the latest changes? |
zadjii-msft
approved these changes
Feb 18, 2022
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Griese <migrie@microsoft.com>
lhecker
added
the
AutoMerge
|
Hello @lhecker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
carlos-zamora
pushed a commit
that referenced
this pull request
May 12, 2022
"Acrylic material" is the official name as used on Microsoft Docs and should ensure it gets properly translated in all languages. ## PR Checklist * [x] Closes #9846 * [x] Closes MSFT:36776499 * [x] I work here ## Detailed Description of the Pull Request / Additional comments We originally intended to replace the strings with "acrylic transparency", but "acrylic material" is actually the official term on Microsoft Docs. (cherry picked from commit 961c576) Service-Card-Id: 81744865 Service-Version: 1.13
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Acrylic material" is the official name as used on Microsoft Docs
and should ensure it gets properly translated in all languages.
PR Checklist
Detailed Description of the Pull Request / Additional comments
We originally intended to replace the strings with "acrylic transparency",
but "acrylic material" is actually the official term on Microsoft Docs.