Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "acrylic" with "acrylic material" in i18n strings #12505

Merged
4 commits merged into from
Feb 18, 2022
Merged

Replace "acrylic" with "acrylic material" in i18n strings #12505

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac55a18
Replace "acrylic" with "acrylic material" in i18n strings
lhecker Feb 16, 2022
e3c3de3
Address feedback
lhecker Feb 17, 2022
8b65a83
Address feedback
lhecker Feb 17, 2022
5f76de6
Address feedback
lhecker Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/cascadia/profiles.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1761,7 +1761,7 @@
},
"useAcrylicInTabRow": {
"default": false,
"description": "When set to true, the tab row will have an acrylic background with 50% opacity.",
"description": "When set to true, the tab row will have an acrylic material background with 50% opacity.",
"type": "boolean"
},
"actions": {
Expand Down Expand Up @@ -2224,7 +2224,7 @@
},
"useAcrylic": {
"default": false,
"description": "When set to true, the window will have an acrylic background. When set to false, the window will have a plain, untextured background.",
"description": "When set to true, the window will have an acrylic material background. When set to false, the window will have a plain, untextured background.",
"type": "boolean"
}
},
Expand Down
26 changes: 7 additions & 19 deletions src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,12 +364,12 @@
<comment>A description for what the "show titlebar" setting does. Presented near "Globals_ShowTitlebar.Header".</comment>
</data>
<data name="Globals_AcrylicTabRow.Header" xml:space="preserve">
<value>Show acrylic in tab row (requires relaunch)</value>
<comment>Header for a control to toggle whether acrylic shows in the tab row. Changing this setting requires the user to relaunch the app.</comment>
<value>Use acrylic material in the tab row (requires relaunch)</value>
<comment>Header for a control to toggle whether "acrylic material" is used. "Acrylic material" is a Microsoft-specific term: https://docs.microsoft.com/en-us/windows/apps/design/style/acrylic</comment>
</data>
<data name="Globals_AcrylicTabRow.HelpText" xml:space="preserve">
<value>When checked, the tab row will have the acrylic material.</value>
<comment>A description for what the "use acrylic in tab row" setting does. Presented near "Globals_AcrylicTabRow.Header".</comment>
<comment>A description for the "Globals_AcrylicTabRow.Header" setting does. "Acrylic material" is a Microsoft-specific term: https://docs.microsoft.com/en-us/windows/apps/design/style/acrylic</comment>
</data>
<data name="Globals_ShowTitleInTitlebar.Header" xml:space="preserve">
<value>Use active terminal title as application title</value>
Expand Down Expand Up @@ -519,14 +519,6 @@
<value>Actions</value>
<comment>Tooltip for the "actions" menu item.</comment>
</data>
<data name="Profile_AcrylicOpacity.Header" xml:space="preserve">
<value>Acrylic opacity</value>
<comment>Header for a control to determine the level of opacity for the acrylic rendering material. The user can choose to make the acrylic background of the app more or less opaque.</comment>
</data>
<data name="Profile_AcrylicOpacity.HelpText" xml:space="preserve">
<value>Sets the transparency of the window.</value>
<comment>A description for what the "acrylic opacity" setting does. Presented near "Profile_AcrylicOpacity.Header".</comment>
</data>
<data name="Profile_OpacitySlider.[using:Windows.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Background opacity</value>
<comment>Name for a control to determine the level of opacity for the background of the control. The user can choose to make the background of the app more or less opaque.</comment>
Expand Down Expand Up @@ -976,12 +968,12 @@
<comment>Button label that deletes the unfocused appearance for this profile.</comment>
</data>
<data name="Profile_UseAcrylic.Header" xml:space="preserve">
<value>Enable acrylic</value>
<comment>Header for a control to toggle the acrylic-like rendering of the background. The acrylic material creates a translucent texture.</comment>
<value>Enable acrylic material</value>
<comment>Header for a control to toggle the use of acrylic material for the background. "Acrylic material" is a Microsoft-specific term: https://docs.microsoft.com/en-us/windows/apps/design/style/acrylic</comment>
</data>
<data name="Profile_UseAcrylic.HelpText" xml:space="preserve">
<value>Applies a translucent texture to the background of the window.</value>
<comment>A description for what the "enable acrylic" setting does. Presented near "Profile_UseAcrylic".</comment>
<comment>A description for what the "Profile_UseAcrylic" setting goes.</comment>
lhecker marked this conversation as resolved.
Show resolved Hide resolved
</data>
<data name="Profile_UseDesktopImage.Content" xml:space="preserve">
<value>Use desktop wallpaper</value>
Expand Down Expand Up @@ -1166,13 +1158,9 @@
<value>Name</value>
<comment>Header for a control to determine the name of the profile. This is a text box.</comment>
</data>
<data name="Profile_AcrylicHeader.Text" xml:space="preserve">
<value>Acrylic</value>
<comment>Header for a group of settings related to the acrylic texture rendering on the background of the app.</comment>
</data>
<data name="Profile_TransparencyHeader.Text" xml:space="preserve">
<value>Transparency</value>
<comment>Header for a group of settings related to transparency, including the acrylic texture rendering on the background of the app.</comment>
<comment>Header for a group of settings related to transparency, including the acrylic material background of the app.</comment>
</data>
<data name="Profile_BackgroundHeader.Text" xml:space="preserve">
<value>Background image</value>
Expand Down