Fixed crash when cloud shell provider timed out or was closed waiting for login #16364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
approved these changes
Nov 27, 2023
|
Thanks @lhecker - lmk if I need to fill out anything else to get it merged, or if you're taking it from here. |
zadjii-msft
approved these changes
Nov 30, 2023
DHowett
pushed a commit
that referenced
this pull request
Dec 4, 2023
… for login (#16364) ## Summary of the Pull Request Cloud shell connection calls out to Azure to do a device code login. When the polling interval is exceeded or the tab is closed, the method doing the connection polling returns `nullptr`, and `AzureConnection` immediately tries to `GetNamedString` from it, causing a crash. This doesn't repro on Terminal Stable or Preview, suggesting it's pretty recent related to the update of this azureconnection. This is just a proposed fix, not sure if you want to do more extensive changes to the affected class or not, so marking this as a draft. ## References and Relevant Issues * N/A - encountered this while using the terminal myself ## PR Checklist/Validation Tested out a local dev build: - [x] Terminal doesn't crash when cloudshell polling interval exceeded - [x] Terminal doesn't crash when cloudshell tab closed while polling for Azure login (cherry picked from commit 0c4751b) Service-Card-Id: 91232784 Service-Version: 1.19
DHowett
pushed a commit
that referenced
this pull request
Jan 23, 2024
… for login (#16364) ## Summary of the Pull Request Cloud shell connection calls out to Azure to do a device code login. When the polling interval is exceeded or the tab is closed, the method doing the connection polling returns `nullptr`, and `AzureConnection` immediately tries to `GetNamedString` from it, causing a crash. This doesn't repro on Terminal Stable or Preview, suggesting it's pretty recent related to the update of this azureconnection. This is just a proposed fix, not sure if you want to do more extensive changes to the affected class or not, so marking this as a draft. ## References and Relevant Issues * N/A - encountered this while using the terminal myself ## PR Checklist/Validation Tested out a local dev build: - [x] Terminal doesn't crash when cloudshell polling interval exceeded - [x] Terminal doesn't crash when cloudshell tab closed while polling for Azure login (cherry picked from commit 0c4751b) Service-Card-Id: 91232783 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Cloud shell connection calls out to Azure to do a device code login. When the polling interval is exceeded or the tab is closed, the method doing the connection polling returns
nullptr, andAzureConnectionimmediately tries toGetNamedStringfrom it, causing a crash. This doesn't repro on Terminal Stable or Preview, suggesting it's pretty recent related to the update of this azureconnection.This is just a proposed fix, not sure if you want to do more extensive changes to the affected class or not, so marking this as a draft.
References and Relevant Issues
PR Checklist/Validation
Tested out a local dev build: