Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed crash when cloud shell provider timed out or was closed waiting for login #16364

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fixed crash when cloud shell provider timed out or was closed waiting for login #16364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/cascadia/TerminalConnection/AzureConnection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,15 @@ namespace winrt::Microsoft::Terminal::TerminalConnection::implementation

// Wait for user authentication and obtain the access/refresh tokens
auto authenticatedResponse = _WaitForUser(devCode, pollInterval, expiresIn);

// If user closed tab, `_WaitForUser` returns nullptr
// This also occurs if the connection times out, when polling time exceeds the expiry time
if (!authenticatedResponse)
{
_transitionToState(ConnectionState::Failed);
return;
}

_setAccessToken(authenticatedResponse.GetNamedString(L"access_token"));
_refreshToken = authenticatedResponse.GetNamedString(L"refresh_token");

Expand Down
Loading