Update CommandPalette.cpp to ignore _filterTextChanged on TabSwitchMode #16858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lhecker
approved these changes
Mar 12, 2024
DHowett
approved these changes
Mar 14, 2024
DHowett
pushed a commit
that referenced
this pull request
Mar 21, 2024
…de (#16858) As mentioned in #11146, when the "Next/Prev" command is executed from the command line with a string in the search bar, this is setting always the first tab. When using the command "Next/Previous Tab" from the command line, we are creating another tab (as if we are using the keyboard shortcut), and this triggers the `_filterTextChanged` that resets the index to the first item in because the current mode that it has. This could be cause because, It seems that it detects as if we are deleting the entered letter or creating an empty string, causing the execution of the mentioned method and resetting its index to 0. To avoid this, we are making sure that when this action is triggerd and we are in the `TabSwitchMode`, we should ignore the following execution of the method. ## Validation Steps Performed I tested out the following scenarios: 1. Performing the action with the keyboard shorcut 2. Perfoming the action with an empty string 3. Performing the action with a string in the search bar. Also validated with the current tests. Closes #11146 (cherry picked from commit 806d5e2) Service-Card-Id: 92139800 Service-Version: 1.20
DHowett
pushed a commit
that referenced
this pull request
Mar 21, 2024
…de (#16858) As mentioned in #11146, when the "Next/Prev" command is executed from the command line with a string in the search bar, this is setting always the first tab. When using the command "Next/Previous Tab" from the command line, we are creating another tab (as if we are using the keyboard shortcut), and this triggers the `_filterTextChanged` that resets the index to the first item in because the current mode that it has. This could be cause because, It seems that it detects as if we are deleting the entered letter or creating an empty string, causing the execution of the mentioned method and resetting its index to 0. To avoid this, we are making sure that when this action is triggerd and we are in the `TabSwitchMode`, we should ignore the following execution of the method. ## Validation Steps Performed I tested out the following scenarios: 1. Performing the action with the keyboard shorcut 2. Perfoming the action with an empty string 3. Performing the action with a string in the search bar. Also validated with the current tests. Closes #11146 (cherry picked from commit 806d5e2) Service-Card-Id: 92139799 Service-Version: 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
As mentioned in the issue #11146, when the "Next/Prev" command is executed from the command line with a string in the search bar, this is setting always the first tab.
References and Relevant Issues
#11146
Detailed Description of the Pull Request / Additional comments
When using the command "Next/Previous Tab" from the command line, we are creating another tab (as if we are using the keyboard shortcut), and this triggers the
_filterTextChangedthat resets the index to the first item in because the current mode that it has.This could be cause because, It seems that it detects as if we are deleting the entered letter or creating an empty string, causing the execution of the mentioned method and resetting its index to 0.
To avoid this, we are making sure that when this action is triggerd and we are in the
TabSwitchMode, we should ignore the following execution of the method.Validation Steps Performed
I tested out the following scenarios:
Also validated with the current tests.
PowerShell.2024-03-10.21-43-29.mp4
PR Checklist