Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CommandPalette.cpp to ignore _filterTextChanged on TabSwitchMode #16858

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Update CommandPalette.cpp to ignore _filterTextChanged on TabSwitchMode #16858

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4195643
Update CommandPalette.cpp to ignore _filterTextChanged on TabSwitchMode
AlejandroBlanco2001 Mar 10, 2024
160700e
Fixing spelling issues
AlejandroBlanco2001 Mar 11, 2024
696cb27
Fixing spelling issues again
AlejandroBlanco2001 Mar 11, 2024
015625d
Fixing formatting
AlejandroBlanco2001 Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/cascadia/TerminalApp/CommandPalette.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,6 +843,16 @@ namespace winrt::TerminalApp::implementation
void CommandPalette::_filterTextChanged(const IInspectable& /*sender*/,
const Windows::UI::Xaml::RoutedEventArgs& /*args*/)
{
// When we are executing the _SelectNextTab in the TabManagement.cpp, this method
// is getting triggered because we set up the default value for that CommandPalette
// with an empty string. Therefore, to avoid the reset of the index when executing
// the Next/Prev tab command, we are skipping this execution.
// Check issue https://github.com/microsoft/terminal/issues/11146
if (_currentMode == CommandPaletteMode::TabSwitchMode)
{
return;
}

if (_currentMode == CommandPaletteMode::CommandlineMode)
{
_evaluatePrefix();
Expand Down
Loading