Introduce UiaRenderer project #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett-MSFT
approved these changes
Sep 27, 2019
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Code format! |
ghost
requested review from
zadjii-msft
reviewed
Oct 1, 2019
| @@ -250,6 +250,8 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "LocalTests_TerminalApp", "s | |||
| EndProject | |||
| Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "winconpty", "src\winconpty\winconpty.vcxproj", "{58A03BB2-DF5A-4B66-91A0-7EF3BA01269A}" | |||
| EndProject | |||
| Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "RendererUia", "src\renderer\uia\lib\uia.vcxproj", "{48D21369-3D7B-4431-9967-24E81292CF63}" | |||
There was a problem hiding this comment.
Be careful with #2949 coming to explode this file
miniksa
previously requested changes
Oct 11, 2019
ghost
added
the
Needs-Author-Feedback
4 tasks
ghost
removed
the
Needs-Author-Feedback
|
No clue why the CI is failing me. @DHowett-MSFT mind taking a look when you get the chance? Builds and deploys just fine. |
|
@zadjii-msft's change to |
zadjii-msft
approved these changes
Oct 28, 2019
DHowett-MSFT
pushed a commit
that referenced
this pull request
Dec 17, 2019
We unintentionally broke the build in #2930. If you're building the entire solution, then you won't have any problems, because the `UiaRenderer` project will get built before the `TerminalControl`. However, if you're like me and you only really build the solution one project at a time, you'll find that building `TerminalControl` won't build `UiaRenderer` automagically. This fixes that. s/o to @Rrogntudju for catching this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
As a part of setting up UIA Events, we need to be able to identify WHEN to notify the client. We'll be adopting the RendererEngine model that the VTRenderer and DxRenderer follow to identify when something on the screen is changing and what to alert the automation clients about.
This PR just introduces the UiaRenderer. There's a lot of E_NOTIMPLs and a few comments throughout as to my thoughts. This'll make diffing future PRs easier and can make this process more iterative. The code does run with the PR so I plan on merging this into master as normal.
Here's the game plan:
References
#2447
PR Checklist
Tests added/passedRequires documentation to be updatedDetailed Description of the Pull Request / Additional comments
There's definitely some functions that we won't be using and we should just return S_FALSE on. But the ones that return E_NOTIMPL are the ones I plan on actually populating.
Validation Steps Performed
Build passes.