Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce UiaRenderer project #2930

Merged
merged 10 commits into from
Oct 28, 2019
Merged

Introduce UiaRenderer project #2930

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ca49fb0
Introduce UiaRenderer project
carlos-zamora Sep 27, 2019
edba0f0
audit mode errors
carlos-zamora Sep 27, 2019
9f687d5
PR nits
carlos-zamora Oct 1, 2019
819eae4
Griese PR changes
carlos-zamora Oct 1, 2019
c70b7dd
Niksa PR Changes
carlos-zamora Oct 15, 2019
76c5fb2
stupid CI issues
carlos-zamora Oct 18, 2019
4ed0a41
preemptive just in case
carlos-zamora Oct 18, 2019
faa723d
Merge branch 'master' into dev/cazamor/acc/signaling
carlos-zamora Oct 23, 2019
7d5c2cb
static analysis fix
carlos-zamora Oct 23, 2019
3ed0cff
code format
carlos-zamora Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/renderer/uia/UiaRenderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ using namespace Microsoft::Console::Types;
// Routine Description:
// - Constructs a UIA engine for console text
// which primarily notifies automation clients of any activity
UiaEngine::UiaEngine() :
UiaEngine::UiaEngine() noexcept:
_isPainting(false),
carlos-zamora marked this conversation as resolved.
Show resolved Hide resolved
_isEnabled(false),
RenderEngineBase() {}
carlos-zamora marked this conversation as resolved.
Show resolved Hide resolved

// Routine Description:
Expand Down Expand Up @@ -369,7 +371,7 @@ UiaEngine::~UiaEngine()
// - <none>
// Return Value:
// - Rectangle describing dirty area in characters.
[[nodiscard]] SMALL_RECT UiaEngine::GetDirtyRectInChars()
[[nodiscard]] SMALL_RECT UiaEngine::GetDirtyRectInChars() noexcept
{
return {};
carlos-zamora marked this conversation as resolved.
Show resolved Hide resolved
}
Expand Down
6 changes: 3 additions & 3 deletions src/renderer/uia/UiaRenderer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace Microsoft::Console::Render
class UiaEngine final : public RenderEngineBase
{
public:
UiaEngine();
UiaEngine() noexcept;
~UiaEngine();
UiaEngine(const UiaEngine&) = default;
UiaEngine(UiaEngine&&) = default;
Expand Down Expand Up @@ -72,12 +72,12 @@ namespace Microsoft::Console::Render

[[nodiscard]] HRESULT GetProposedFont(const FontInfoDesired& fiFontInfoDesired, FontInfo& fiFontInfo, int const iDpi) noexcept override;

[[nodiscard]] SMALL_RECT GetDirtyRectInChars() override;
[[nodiscard]] SMALL_RECT GetDirtyRectInChars() noexcept override;
[[nodiscard]] HRESULT GetFontSize(_Out_ COORD* const pFontSize) noexcept override;
[[nodiscard]] HRESULT IsGlyphWideByFont(const std::wstring_view glyph, _Out_ bool* const pResult) noexcept override;

protected:
[[nodiscard]] virtual HRESULT _DoUpdateTitle(const std::wstring& newTitle) noexcept override;
[[nodiscard]] HRESULT _DoUpdateTitle(const std::wstring& newTitle) noexcept override;

private:
bool _isEnabled;
Expand Down