Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rename model with custom code #4256

Closed
m-nash opened this issue Aug 26, 2024 · 1 comment · Fixed by #4285
Closed

Support rename model with custom code #4256

m-nash opened this issue Aug 26, 2024 · 1 comment · Fixed by #4285
Assignees
@ArcturusZhang
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@m-nash
Copy link
Member

m-nash commented Aug 26, 2024 •
edited
Loading

Support https://github.com/Azure/autorest.csharp/blob/feature/v3/readme.md#rename-a-model-class
@m-nash m-nash added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Aug 26, 2024
@microsoft microsoft deleted a comment Aug 26, 2024
@ArcturusZhang ArcturusZhang self-assigned this Aug 28, 2024
@ArcturusZhang ArcturusZhang mentioned this issue Aug 28, 2024
Merged
@ArcturusZhang
Copy link
Member

I only supported CodeGenType, which is quite universal that could the name and namespace of any generated type.
Do we still need the CodeGenModel attribute? Maybe we could remove it. The extra feature in the CodeGenModel attribute is that it could change or append usage to the model.

github-merge-queue bot pushed a commit that referenced this issue Sep 4, 2024
@ArcturusZhang
implement the feature of changing the name of a model (#4285)
cd6e362 
Fixes #4256 
Fixes #4261

In order to get our mocking system working properly and make everything
aligned, I changed the `SourceInputModel` to public and added it to the
`CodeModelPlugin` so that our plugin writers could override something on
it to do some advanced stuffs
sarangan12 pushed a commit to sarangan12/typespec that referenced this issue Sep 16, 2024
@ArcturusZhang @sarangan12
implement the feature of changing the name of a model (microsoft#4285)
860bb18 
Fixes microsoft#4256 
Fixes microsoft#4261

In order to get our mocking system working properly and make everything
aligned, I changed the `SourceInputModel` to public and added it to the
`CodeModelPlugin` so that our plugin writers could override something on
it to do some advanced stuffs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArcturusZhang ArcturusZhang

Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement the feature of changing the name of a model microsoft/typespec
2 participants
@ArcturusZhang @m-nash