implement the feature of changing the name of a model #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
ArcturusZhang
commented
Aug 28, 2024
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/TypeProvider.cs
Outdated
Show resolved
Hide resolved
ArcturusZhang
commented
Aug 28, 2024
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/TypeProvider.cs
Outdated
Show resolved
Hide resolved
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
...ages/http-client-csharp/generator/Microsoft.Generator.CSharp/test/TestHelpers/MockHelpers.cs
Outdated
Show resolved
Hide resolved
...enerator/Microsoft.Generator.CSharp/test/Providers/ModelProviders/ModelCustomizationTests.cs
Outdated
Show resolved
Hide resolved
m-nash
reviewed
Aug 29, 2024
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Configuration.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Configuration.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/CodeModelPlugin.cs
Outdated
Show resolved
Hide resolved
...-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/NamedTypeSymbolProvider.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/TypeProvider.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/test/CSharpGenTests.cs
Outdated
Show resolved
Hide resolved
...enerator/Microsoft.Generator.CSharp/test/Providers/ModelProviders/ModelCustomizationTests.cs
Outdated
Show resolved
Hide resolved
...harp/test/Providers/TestData/ModelCustomizationTests/TestCustomization_CanChangeModelName.cs
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/TypeProvider.cs
Outdated
Show resolved
Hide resolved
...enerator/Microsoft.Generator.CSharp/test/Providers/ModelProviders/ModelCustomizationTests.cs
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/test/Helpers.cs
Show resolved
Hide resolved
m-nash
approved these changes
Sep 4, 2024
sarangan12
pushed a commit
to sarangan12/typespec
that referenced
this pull request
Sep 16, 2024
Fixes microsoft#4256 Fixes microsoft#4261 In order to get our mocking system working properly and make everything aligned, I changed the `SourceInputModel` to public and added it to the `CodeModelPlugin` so that our plugin writers could override something on it to do some advanced stuffs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4256
Fixes #4261
In order to get our mocking system working properly and make everything aligned, I changed the
SourceInputModelto public and added it to theCodeModelPluginso that our plugin writers could override something on it to do some advanced stuffs