Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Semantic walker doesn't fire various exit methods #4588

Closed
4 tasks done
swatkatz opened this issue Oct 2, 2024 · 0 comments · Fixed by #4626
Closed
4 tasks done

[Bug]: Semantic walker doesn't fire various exit methods #4588

swatkatz opened this issue Oct 2, 2024 · 0 comments · Fixed by #4626
Labels
bug Something isn't working needs-area

Comments

@swatkatz
Copy link
Contributor

swatkatz commented Oct 2, 2024

Describe the bug

The emit is missing from these methods.

Reproduction

navigateInterfaceType(type: Interface, context: NavigationContext) {
     context.emit("exitInterface")

navigateEnumType(type: Enum, context: NavigationContext) {
    context.emit("exitEnum")

navigateUnionType(type: Union, context: NavigationContext) {
    context.emit("exitUnion")


function navigateUnionTypeVariant(type: UnionVariant, context: NavigationContext) {
     context.emit("exitUnionVariant")

Checklist

@swatkatz swatkatz added the bug Something isn't working label Oct 2, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 9, 2024
Fixes: #4588

This won't call the post order exit callbacks if recursion stops at
pre-order callbacks.

---------

Co-authored-by: swatikumar <swatikumar@pinterest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant