Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing exit callbacks #4626

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

swatkatz
Copy link
Contributor

@swatkatz swatkatz commented Oct 7, 2024

Fixes: #4588

This won't call the post order exit callbacks if recursion stops at pre-order callbacks.

@swatkatz
Copy link
Contributor Author

swatkatz commented Oct 7, 2024

@microsoft-github-policy-service agree

@swatkatz
Copy link
Contributor Author

swatkatz commented Oct 8, 2024 via email

@bterlson
Copy link
Member

bterlson commented Oct 8, 2024

I'm confused about why the collector needs to collect on exit also, but that is I suppose a separable issue since it is doing so already for some things.

@timotheeguerin timotheeguerin added this pull request to the merge queue Oct 9, 2024
Merged via the queue into microsoft:main with commit 010ebde Oct 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Semantic walker doesn't fire various exit methods
3 participants