feat: use the browser networks stack as fallback when direct load fails #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome recently(ish) added a `Network.loadNetworkResource` request which allows us to ask the browser to load a resource, and get the response. Instead of our previous hacky method of asking and then applying cookies manually, which only worked for some scenarios, use this method as a fallback if manually requesting the resource fails. Do some rearranging since previously the SourceMapFactory was global which prevented it from using session-specific data. Fixes #1766 Fixes #425 (3 years later!)
|
No new unit tests here since the cookie scenario, which this implements in a better way, already has tests. |
rzhao271
reviewed
Aug 2, 2023
rzhao271
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome recently(ish) added a
Network.loadNetworkResourcerequest whichallows us to ask the browser to load a resource, and get the response.
Instead of our previous hacky method of asking and then applying cookies
manually, which only worked for some scenarios, use this method as a
fallback if manually requesting the resource fails.
Do some rearranging since previously the SourceMapFactory was global
which prevented it from using session-specific data.
Fixes #1766
Fixes #425 (3 years later!)