-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation issue: Source map authentication #192895
Comments
This refers to microsoft/vscode-js-debug#1772, which uses the browser's network stack if we can't externally request the sourcemaps. This allows any authentication state that may be present for the sourcemap's path (like auth cookies) to be given in the request. The full scope of what exactly is included and how redirects are handled are up to the browser. |
That's great! I really appreciate your work on this, it's a big deal! So whatever auth the browser can handle automatically, eg cookie auth or possibly client certs. Thank you for the additional info. I do think that this should be reflected in the documentation, but my information needs are met (also feel free to paste into https://stackoverflow.com/questions/77090708/vs-code-aug-2023-how-can-source-maps-be-automatically-loaded-from-authenticated if you want some SO points). Shall I leave it open for docs, or close it? |
I'm not sure what it'd be useful to say in the docs about it -- there's no configuration available for this behavior, it 'just happens'. What information about it do you think would be relevant for users? |
I was thinking something along the lines of:
I think this should go on the browser debugging page. I searched and searched for any info on what sourcemap authentication is supported by User Agents and couldn't find anything useful. |
This issue is to obtain sufficient documentation for a claimed new feature to be used.
The release notes from the newest (Aug 2023) VS Code release says:
That's great! But to use this, we need some more info:
I haven't been able to find any info on this in the release notes or VS Code docs. I would expect more info on the browser debugging page or the Node debugging page. This seems like a browser debugging feature, b/c securing source maps seems more critical for front-end code than back-end code.
The text was updated successfully, but these errors were encountered: