Fix off-by-one error with end column (#64)

* fix: end offset + 1 * test: fix tests to be inclusive of last character of diagnostic
microsoft · Jun 23, 2023 · 7bd1c9d · 7bd1c9d
1 parent ea18cf0
commit 7bd1c9d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/bundled/tool/lsp_server.py b/bundled/tool/lsp_server.py
@@ -164,7 +164,7 @@ def _parse_output_using_regex(
             end = start
             if "end_line" in data and "end_column" in data:
                 end_line = int(data["end_line"]) - line_offset
-                end_column = int(data["end_column"]) - col_offset
+                end_column = int(data["end_column"])
                 if end_column == (len(line) - col_offset):
                     end_column = 0
                     end_line += 1

diff --git a/src/test/python_tests/test_linting.py b/src/test/python_tests/test_linting.py
@@ -58,7 +58,7 @@ def _log_handler(params):
             {
                 "range": {
                     "start": {"line": 2, "character": 6},
-                    "end": {"line": 2, "character": 6},
+                    "end": {"line": 2, "character": 7},
                 },
                 "message": 'Name "x" is not defined  ',
                 "severity": 1,
@@ -115,7 +115,7 @@ def _log_handler(params):
             {
                 "range": {
                     "start": {"line": 2, "character": 6},
-                    "end": {"line": 2, "character": 6},
+                    "end": {"line": 2, "character": 7},
                 },
                 "message": 'Name "x" is not defined  ',
                 "severity": 1,
@@ -237,7 +237,7 @@ def _log_handler(params):
             {
                 "range": {
                     "start": {"line": 2, "character": 6},
-                    "end": {"line": 2, "character": 6},
+                    "end": {"line": 2, "character": 7},
                 },
                 "message": 'Name "x" is not defined  ',
                 "severity": 2,