Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one error with end column #64

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fix off-by-one error with end column #64

merged 2 commits into from
Jun 23, 2023

Conversation

vidhanio
Copy link
Contributor

closes #63

@karthiknadig karthiknadig self-assigned this Jun 23, 2023
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Jun 23, 2023
@karthiknadig karthiknadig changed the title fix: end offset + 1 Fix off-by-one error with end column Jun 23, 2023
@karthiknadig
Copy link
Member

@vidhanio Thanks for PR fixing this bug. Would it be possible for you to update the Tests?

@vidhanio
Copy link
Contributor Author

done @karthiknadig. :)

@karthiknadig karthiknadig self-requested a review June 23, 2023 18:41
@karthiknadig karthiknadig requested review from paulacamargo25, eleanorjboyd and anthonykim1 and removed request for eleanorjboyd June 23, 2023 18:42
@karthiknadig karthiknadig enabled auto-merge (squash) June 23, 2023 18:43
@karthiknadig karthiknadig merged commit 7bd1c9d into microsoft:main Jun 23, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

squiggles are one character too short.
3 participants