Merge pull request #448 from microsoftgraph/bugfixes/$SearchValues

Format Search Values
microsoftgraph · Nov 2, 2020 · 8225941 · 8225941
2 parents f757249 + ecd79e1
commit 8225941
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/readme.graph.md b/src/readme.graph.md
@@ -551,6 +551,10 @@ directive:
           // Call OnBeforeWriteObject to deserialize '@odata.count' from the response object.
           let writeObjectRegex = /^(\s*)(WriteObject\(result\.Value,true\);)$/gm
           $ = $.replace(writeObjectRegex,'\n$1OnBeforeWriteObject(this.InvocationInformation.BoundParameters, result?.AdditionalProperties);\n$1$2');
+
+          // Format all Search values by adding quotes around them.
+          let searchQueryRegex = /this\.InvocationInformation\.BoundParameters\.ContainsKey\("Search"\)\s*\?\s*Search\s*:\s*null/gm
+          $ = $.replace(searchQueryRegex, 'this.FormatSearchValue(this.InvocationInformation.BoundParameters, Search)');
         }
         return $;
       }

diff --git a/tools/Custom/ListCmdlet.cs b/tools/Custom/ListCmdlet.cs
@@ -172,6 +172,27 @@ public bool ShouldIteratePages(global::System.Collections.Generic.Dictionary<str
             return nextLinkUri.Uri;
         }
 
+        /// <summary>
+        /// Adds quotation mark around $search values if none exists.
+        /// This is needed to support KQL e.g. "prop:value".
+        /// </summary>
+        /// <param name="boundParameters">The bound parameters of the calling cmdlet.</param>
+        /// <param name="search">The $search value.</param>
+        /// <returns>A formated search value.</returns>
+        internal string FormatSearchValue(global::System.Collections.Generic.Dictionary<string, object> boundParameters, string search)
+        {
+            if (!boundParameters.ContainsKey("Search"))
+            {
+                return null;
+            }
+            else if (!string.IsNullOrWhiteSpace(search) && !search.StartsWith("\""))
+            {
+                search = $"\"{search}\"";
+            }
+
+            return search;
+        }
+
         internal void OnBeforeWriteObject(global::System.Collections.Generic.Dictionary<string, object> boundParameters, global::System.Collections.Generic.IDictionary<string, object> additionalProperties)
         {
             // Get odata.count from the response.