Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format Search Values #448

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Format Search Values #448

merged 2 commits into from
Nov 2, 2020

Conversation

peombwa
Copy link
Member

@peombwa peombwa commented Oct 27, 2020 •
edited
Loading

In order to support KQL, $Search values should be surrounded by " ". This PR adds FormatSearchValue method that adds double quote marks around $search values if none exists.

Proposed Usage

image

Closes #399 #402 #419

@peombwa peombwa marked this pull request as ready for review October 27, 2020 22:46
@peombwa peombwa self-assigned this Oct 27, 2020
@peombwa peombwa merged commit 8225941 into dev Nov 2, 2020
@peombwa peombwa deleted the bugfixes/$SearchValues branch November 2, 2020 22:26
@peombwa peombwa mentioned this pull request Nov 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgend georgend georgend approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees

@peombwa peombwa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double quotes around $search values
2 participants
@peombwa @georgend