enhance: avoid the coexistence of the old coordinator and the new node/proxy #35720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiliu1031
force-pushed
the
block_standalone_start_progress
branch
from
7bd2f31
to
5dc32bc
Compare
|
/run-cpu-e2e |
mergify
bot
added
dco-passed
|
@weiliu1031 E2e jenkins job failed, comment |
weiliu1031
force-pushed
the
block_standalone_start_progress
branch
from
5dc32bc
to
36edb6e
Compare
|
@weiliu1031 E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35720 +/- ##
==========================================
+ Coverage 81.32% 84.66% +3.34%
==========================================
Files 1238 960 -278
Lines 148082 123447 -24635
==========================================
- Hits 120425 104516 -15909
+ Misses 22887 14154 -8733
- Partials 4770 4777 +7 |
…e/proxy
In standalone mode, block the start process until the new coordinator is active to avoid the coexistence of the old coordinator and the new node/proxy
1. In the start/restart process, the new coordinator will become active immediately and will not be blocked
2. In the rolling upgrade process, the new coordinator will not be active until the old coordinator is down, and it will be blocked
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
weiliu1031
force-pushed
the
block_standalone_start_progress
branch
from
36edb6e
to
4367a7e
Compare
|
@weiliu1031 E2e jenkins job failed, comment |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weiliu1031, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
Aug 29, 2024
…e/proxy (#35760) issue: #35719 pr: #35720 In standalone mode, block the start process until the new coordinator is active to avoid the coexistence of the old coordinator and the new node/proxy 1. In the start/restart process, the new coordinator will become active immediately and will not be blocked 2. In the rolling upgrade process, the new coordinator will not be active until the old coordinator is down, and it will be blocked Signed-off-by: Wei Liu <wei.liu@zilliz.com>
|
/run-cpu-e2e |
|
@weiliu1031 E2e jenkins job failed, comment |
|
/run-cpu-e2e |
weiliu1031
added a commit
to weiliu1031/milvus
that referenced
this pull request
Sep 9, 2024
…d the new node/proxy (milvus-io#35720)" This reverts commit 73be0ba.
weiliu1031
added a commit
to weiliu1031/milvus
that referenced
this pull request
Sep 9, 2024
…d the new node/proxy (milvus-io#35720)" This reverts commit 73be0ba.
weiliu1031
added a commit
to weiliu1031/milvus
that referenced
this pull request
Sep 9, 2024
…d the new node/proxy (milvus-io#35720)" This reverts commit 73be0ba. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Sep 10, 2024
chyezh
pushed a commit
to chyezh/milvus
that referenced
this pull request
Sep 11, 2024
…d the new node/proxy (milvus-io#35720)" (milvus-io#36113) issue: milvus-io#36100 This reverts commit 73be0ba. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #35719
In standalone mode, block the start process until the new coordinator is active to avoid the coexistence of the old coordinator and the new node/proxy
1. In the start/restart process, the new coordinator will become active immediately and will not be blocked
2. In the rolling upgrade process, the new coordinator will not be active until the old coordinator is down, and it will be blocked