fix: Revert "enhance: avoid the coexistence of the old coordinator and the new node/proxy (#35720)" #36113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weiliu1031 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
mergify
bot
added
needs-dco
weiliu1031
force-pushed
the
revert_pr
branch
from
b33d193
to
a1d16ce
Compare
…d the new node/proxy (milvus-io#35720)" This reverts commit 73be0ba. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
weiliu1031
force-pushed
the
revert_pr
branch
from
a1d16ce
to
92a6b8a
Compare
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #36113 +/- ##
==========================================
+ Coverage 81.58% 81.59% +0.01%
==========================================
Files 1267 1267
Lines 150897 150973 +76
==========================================
+ Hits 123108 123189 +81
+ Misses 22901 22890 -11
- Partials 4888 4894 +6 |
sre-ci-robot
pushed a commit
that referenced
this pull request
Sep 9, 2024
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weiliu1031, yanliang567 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chyezh
pushed a commit
to chyezh/milvus
that referenced
this pull request
Sep 11, 2024
…d the new node/proxy (milvus-io#35720)" (milvus-io#36113) issue: milvus-io#36100 This reverts commit 73be0ba. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #36100
This reverts commit 73be0ba.