Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Make all ability names, tower names, ability descriptions all lower case before storing in json or in the table #79

Closed
mithi opened this issue Nov 2, 2020 · 0 comments · Fixed by #86

Comments

@mithi
Copy link
Owner

mithi commented Nov 2, 2020

To be more consistent.

As a corollary, convert to query parameters to lower case before querying them in the database

@mithi mithi linked a pull request Nov 3, 2020 that will close this issue
@mithi mithi closed this as completed in #86 Nov 3, 2020
mithi added a commit that referenced this issue Nov 3, 2020
…data pipeline

1. Tower names, ability names, descriptions, are now all stored in lowercase in the database.
The graphql query arguments will be converted to lower case first before we use them to query 
the database. Updated all tests accordingly.
Solves: #79

2. Fix data saving pipeline
- Improve code format of scripts
- Drop database and user if they exist before creating them
- The data saving pipeline was incorrect, we won't be able to resave the data since the current `seed/populate.js` only allows for` inserts` and not `updates`. In the future, I might change this, but since the data isn't that much anyway, the current implementation is that the user is dropped and recreated and all the data are populated all over again
#43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant