Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Data would all be lowercase + fix setup + update data pipeline #86

Merged
merged 5 commits into from
Nov 3, 2020

Conversation

mithi
Copy link
Owner

@mithi mithi commented Nov 3, 2020

  1. Tower names, ability names, descriptions, are now all stored in lowercase in the database.
    The graphql query arguments will be converted to lower case first before we use them to query
    the database. Updated all tests accordingly.
    Solves: Make all ability names, tower names, ability descriptions all lower case before storing in json or in the table #79

  2. Fix data saving pipeline

  • Improve code format of scripts
  • Drop database and user if they exist before creating them
  • The data saving pipeline was incorrect, we won't be able to resave the data since the current seed/populate.js only allows for inserts and not updates. In the future, I might change this, but since the data isn't that much anyway, the current implementation is that the user is dropped and recreated and all the data are populated all over again
    Improve data saving pipeline #43

@mithi mithi changed the title Data would all be lowcase + fix setup + update data pipeline Data would all be lowercase + fix setup + update data pipeline Nov 3, 2020
@mithi mithi merged commit 4cb3052 into main Nov 3, 2020
@mithi mithi deleted the chores/lowercase-data branch November 5, 2020 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant