Multi arch docker build #104
Conversation
There was a problem hiding this comment.
Thanks for the PR! I looked at the GitHub Action logs for the pull request and things look like they're working.
Could you now update the workflow file so that it can be merged to master?
For instance, Docker credential secrets will have to be brought back into the workflow file. I've marked other places that need modification so that it can land on master.
.github/workflows/push_docker.yaml
Outdated
| @@ -3,7 +3,7 @@ name: Push Docker image | |||
| on: | |||
| push: | |||
| branches: | |||
| - master | |||
| - multi-arch-docker-build | |||
There was a problem hiding this comment.
This can be reverted back to master now, right?
There was a problem hiding this comment.
Hasn't been addressed. Please do a thorough scan of the workflow file to ensure that it can land in master and request review.
.github/workflows/push_docker.yaml
Outdated
| jobs: | ||
| build_and_push: | ||
| if: github.repository_owner == 'ml-energy' | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false |
There was a problem hiding this comment.
It ensures that both platform builds will run to completion, regardless of whether one of them fails. Do you think this is unnecessary?
There was a problem hiding this comment.
Is fail-fast true by default? I think we actually want to fail fast. If one platform failed, it means something is wrong with the Dockerfile and we don't want to upload a partial image.
There was a problem hiding this comment.
I have set fail-fast value to true as it is not true by default.
There was a problem hiding this comment.
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast I think it's true by default. If it is so, let's delete the line.
There was a problem hiding this comment.
Ah sorry, it seems to be true by default. Removed the line!
.github/workflows/push_docker.yaml
Outdated
| uses: docker/login-action@v2 | ||
| with: | ||
| username: ${{ secrets.DOCKER_HUB_USERNAME }} | ||
| password: ${{ secrets.DOCKER_HUB_TOKEN }} |
There was a problem hiding this comment.
The master branch's workflow file would need this, one way or another. In general it seems like this PR is not ready to be merged to master. Please update the workflow file so that it is as it should be on the master branch after merging.
|
https://docs.docker.com/build/ci/github-actions/multi-platform/#distribute-build-across-multiple-runners |
What we want to have is images like this: One tag supports two different architectures. Unless I'm mistaken, I think the GitHub Actions workflow we currently have will create an ARM64 and an AMD64 image separately (independent image with just a single architecture) with the same tag, and the one that finished later will overwrite the one that finished earlier, and we'll end up with either a single-arch ARM64 image or a single-arch AMD64 image. So apparently there are two ways to do this:
Please try both and see which one finishes earlier. We'll use the one that finishes quicket. |
… artifact name from multiple jobs
Summary
This pull request introduces a GitHub Actions workflow to build and push multi-platform Docker images for the Zeus project. The workflow supports both linux/amd64 and linux/arm64 architectures.
Testing and Future Integration
This workflow is currently set up to test on the multi-arch-docker-build branch. The 401 error encountered during the build process is expected to be resolved by including Docker login credentials and pushing to the master branch. Once verified, this workflow will be integrated into the master branch to enable seamless multi-platform image builds and pushes.