Multi arch docker build #104
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ name: Push Docker image | |
| on: | ||
| push: | ||
| branches: | ||
| - multi-arch-docker-build | ||
| tags: | ||
| - zeus-v* | ||
| paths: | ||
|
|
@@ -18,11 +18,20 @@ on: | |
| - 'LICENSE' | ||
| - 'setup.py' | ||
| - 'pyproject.toml' | ||
| pull_request: | ||
| branches: | ||
| - multi-arch-docker-build | ||
jaywonchung marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| jobs: | ||
| build_and_push: | ||
| if: github.repository_owner == 'ml-energy' | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
|
There was a problem hiding this comment. It ensures that both platform builds will run to completion, regardless of whether one of them fails. Do you think this is unnecessary? There was a problem hiding this comment. Is fail-fast There was a problem hiding this comment. I have set fail-fast value to true as it is not true by default. There was a problem hiding this comment. https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast I think it's true by default. If it is so, let's delete the line. There was a problem hiding this comment. Ah sorry, it seems to be true by default. Removed the line! |
||
| matrix: | ||
| platform: | ||
| - linux/amd64 | ||
| - linux/arm64 | ||
|
|
||
| steps: | ||
| - name: Remove unnecessary files | ||
| run: | | ||
|
|
@@ -31,33 +40,32 @@ jobs: | |
| sudo rm -rf "/usr/local/share/boost" | ||
| sudo rm -rf "$AGENT_TOOLSDIRECTORY" | ||
| - name: Checkout repository | ||
|
There was a problem hiding this comment. The |
||
| uses: actions/checkout@v4 | ||
| - name: Setup Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
| - name: Generate image metadata | ||
| id: meta | ||
| uses: docker/metadata-action@v5 | ||
| with: | ||
| images: | | ||
| symbioticlab/zeus | ||
| mlenergy/zeus | ||
| tags: | | ||
| type=ref,event=branch | ||
| type=ref,event=tag | ||
| type=schedule | ||
| type=sha | ||
jaywonchung marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - name: Build and push to Docker Hub | ||
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: . | ||
| file: docker/Dockerfile | ||
| push: false | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
| cache-from: type=registry,ref=mlenergy/zeus:buildcache | ||
| cache-to: type=registry,ref=mlenergy/zeus:buildcache,mode=max | ||
| platforms: ${{ matrix.platform }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be reverted back to
masternow, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hasn't been addressed. Please do a thorough scan of the workflow file to ensure that it can land in
masterand request review.