Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG+1: BUG: info['bads'] order shouldn't matter in write_evokeds() #7954

Merged
merged 3 commits into from
Jul 2, 2020
Merged

MRG+1: BUG: info['bads'] order shouldn't matter in write_evokeds() #7954

merged 3 commits into from
Jul 2, 2020

Commits on Jul 1, 2020

  1. bads order shouldn't matter in Epochs comparison 

    I ran into an issue where I created two Evokeds and their difference
(via combine_evoked); say, `e1`, `e2`, and `diff`.

I then wanted to write those Evokeds to a single file via
`mne.write_evokeds([e1, e2, diff])`, which failed with a
`ValueError`: "info['bads'] must match'". I looked into the `bads`
lists and found that the order of bad channels in `diff` was different
from the order in `e1` and `e2`; yet, the set of channels was identical.

While it probably would make sense to figure out where this difference
comes from, it also got me thinking that an altered `bads` order
shouldn't be a stopper when using `write_evokeds()`, as long as all
passed Evoked objects mark the same channels as bad.

And this is exactly what this commit implements.
    @hoechenberger
    hoechenberger committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    7fcd0ae View commit details
    Browse the repository at this point in the history

  2. Typo

    @hoechenberger
    hoechenberger committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    6b603aa View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @hoechenberger
    hoechenberger committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    38207c6 View commit details
    Browse the repository at this point in the history