MRG+1: BUG: info['bads'] order shouldn't matter in write_evokeds() #7954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
I ran into an issue where I created two Evokeds and their difference (via
combine_evoked()
); say,e1
,e2
, anddiff
.I then wanted to write those Evokeds to a single file via
mne.write_evokeds([e1, e2, diff])
, which failed with aValueError
: "info['bads'] must match'". I looked into thebads
lists and found that the order of bad channels indiff
was different from the order ine1
ande2
; yet, the set of channels was identical.While it probably would make sense to figure out where this difference comes from, it also got me thinking that an altered
bads
order shouldn't be a stopper when usingwrite_evokeds()
, as long as all passed Evoked objects mark the same channels as bad.And this is exactly what this PR implements.