-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: Add time player for the notebook backend #7940
MRG: Add time player for the notebook backend #7940
Conversation
I noticed incompatibilities between the orientation controller and the general camera settings. I will take care of that in another PR. |
works like a charm on my machine
|
The warnings on Circle don't seem related to this PR:
|
I'll look into CircleCI |
I think this is ready to go now. |
works great ! to discuss (in a next PR if you want) is if it's wiser to specify time in ms and not in time index in the slider. I would personally prefer to show time in ms |
One problem is that a lot of times (cluster summary, custom STCs) milliseconds are not the units and don't really make sense. Time index is at least agnostic to this problem. In theory the |
ok fair enough. Let's postpone such discussion / improvements
+1 for merge
… |
Works great! |
* upstream/master: (30 commits) MRG: Add remove_labels to _Brain (mne-tools#7964) Add get_picked_points (mne-tools#7963) ENH: Add OpenGL info to mne sys_info (mne-tools#7976) [MRG] Fix reject_tmin and reject_tmax for reject_by_annotation in mne.Epochs (mne-tools#7967) mrg: Add scalar mult and div operators for AverageTFR (mne-tools#7957) MRG, MAINT: Cleaner workaround for Sphinx linking issue (mne-tools#7970) MRG, ENH: Speed up epochs.copy (mne-tools#7968) MRG, BUG: Allow ref mags to have a comp grade (mne-tools#7965) do not forget to pass adjacency (mne-tools#7961) [MRG] fix Issue with stc.project after restricting to a label (mne-tools#7950) Only process nirx event file if present (mne-tools#7951) MRG+1: BUG: info['bads'] order shouldn't matter in write_evokeds() (mne-tools#7954) Fix some small glitches introduced via mne-tools#7845 (mne-tools#7952) Add time player (mne-tools#7940) MAINT: Clean up VTK9 offset array [circle front] (mne-tools#7953) MAINT: Skip a few more on macOS (mne-tools#7948) fix links [skip travis] (mne-tools#7949) MRG, MAINT: Tweak CIs (mne-tools#7943) MRG, BUG: Fix vector scaling (mne-tools#7934) MRG, VIZ, BUG: handle CSD channel type when topo plotting (mne-tools#7935) ...
This PR adds a "player" controller for the time slider with play, pause, stop and rewind. It also reorders the controllers for a cleaner UI.
It's part of #7162